Skip to content

Comments

Add Flask logo demo#72

Merged
Gudahtt merged 4 commits intomainfrom
flask-logo
Oct 14, 2021
Merged

Add Flask logo demo#72
Gudahtt merged 4 commits intomainfrom
flask-logo

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Oct 7, 2021

A demo has been added for the Flask logo. It uses per-chunk gradients.

@Gudahtt
Copy link
Member Author

Gudahtt commented Oct 7, 2021

This depends upon #72

@Gudahtt Gudahtt mentioned this pull request Oct 7, 2021
@Gudahtt
Copy link
Member Author

Gudahtt commented Oct 7, 2021

Also I need to confirm a few of these colors first, especially the back color. Right now it's using the forehead gradient, but it probably deserves its own.

@Gudahtt Gudahtt force-pushed the add-gradient-support branch from 4d3262e to f4e970b Compare October 7, 2021 20:46
@Gudahtt Gudahtt force-pushed the add-gradient-support branch from f1569cd to c0367a4 Compare October 12, 2021 12:39
@Gudahtt Gudahtt force-pushed the flask-logo branch 2 times, most recently from 1ec5f9e to bc033a4 Compare October 12, 2021 13:18
@Gudahtt Gudahtt force-pushed the add-gradient-support branch from c0367a4 to 21f2416 Compare October 12, 2021 20:18
@Gudahtt Gudahtt force-pushed the add-gradient-support branch from 21f2416 to 0e3fb23 Compare October 12, 2021 22:06
Base automatically changed from add-gradient-support to main October 13, 2021 12:18
@Gudahtt
Copy link
Member Author

Gudahtt commented Oct 13, 2021

Alright, this is now good to go! I think the colors are all OK now.

@Gudahtt Gudahtt marked this pull request as ready for review October 13, 2021 14:58
@Gudahtt Gudahtt requested a review from a team as a code owner October 13, 2021 14:58
rekmarks
rekmarks previously approved these changes Oct 13, 2021
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

A demo has been added for the Flask logo. It uses per-chunk gradients.
@Gudahtt
Copy link
Member Author

Gudahtt commented Oct 13, 2021

This branch has been rebased to resolve conflicts. The only change was to move where the flask-fox.json is located, and to delete the bundle.

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this deployed!

@Gudahtt Gudahtt merged commit f59582e into main Oct 14, 2021
@Gudahtt Gudahtt deleted the flask-logo branch October 14, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants