colocate tests in flat structure #10655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Keeping the |
Gudahtt
reviewed
Mar 15, 2021
brad-decker
commented
Mar 15, 2021
Contributor
Author
There was a problem hiding this comment.
I straight-up murdered this test cause I couldn't figure out wtf it was trying to do or why it had a mock store.
Contributor
Author
There was a problem hiding this comment.
and there was already a test file with test cases for this component in the directory in question
Collaborator
Builds ready [d19d046]
Page Load Metrics (653 ± 25 ms)
|
brad-decker
force-pushed
the
colocate-flat-tests
branch
3 times, most recently
from
4dd7dcb to
080898e
Compare
Collaborator
Builds ready [080898e]
Page Load Metrics (623 ± 35 ms)
|
brad-decker
force-pushed
the
colocate-flat-tests
branch
from
080898e to
3d22d39
Compare
Collaborator
Builds ready [3d22d39]
Page Load Metrics (734 ± 78 ms)
|
Gudahtt
reviewed
Mar 16, 2021
| @@ -0,0 +1,82 @@ | |||
| import assert from 'assert'; | |||
| import freeze from 'deep-freeze-strict'; | |||
| import reducers from '../ducks'; | |||
Member
There was a problem hiding this comment.
This seems to be testing the reducers more than the action constants 🤔
This is definitely a huge improvement from how these were organized before though!
Gudahtt
reviewed
Mar 16, 2021
| "test:unit:global": "mocha --exit --require test/env.js --require test/setup.js --recursive test/unit-global/*.test.js", | ||
| "test:unit:lax": "mocha --exit --require test/env.js --require test/setup.js --recursive \"test/unit/{,**/!(permissions)}/*.test.js\" \"ui/app/**/*.test.js\" \"shared/**/*.test.js\"", | ||
| "test:unit:strict": "mocha --exit --require test/env.js --require test/setup.js --recursive \"test/unit/**/permissions/*.test.js\"", | ||
| "test:unit:lax": "mocha --exit --require test/env.js --require test/setup.js --recursive './{ui,app,shared}/{,**/!(permissions)}/*.test.js'", |
Member
There was a problem hiding this comment.
This could exclude other directories named "permissions" as well. I don't think we have any right now, but that's an unfortunate foot-fun to leave laying around.
I'll try to think of an alternative syntax, and we can fix it in a follow-up PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves test files to be colocated with the code under test, without nesting in
testfolders.A: Put it in
test/helpers/,test/mocks/ortest/stubs/-- whichever is most relevant