Fix #15050 - MV3: Keep the user logged in when service worker restarts #15301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
commented
Jul 20, 2022
|
|
||
| // Log them in if possible | ||
| if (isManifestV3()) { | ||
| chrome.storage.local.get(['decryptedKey']).then(({ key }) => { |
Contributor
Author
There was a problem hiding this comment.
I'm not convinced this is the best place for this call, but parking it here for now, since we attempt password submission right above it.
Member
There was a problem hiding this comment.
this should be chrome.storage.session right?
Member
|
be sure to include "delete key on user log out" to the requirements/testing |
Contributor
Author
|
Closing as our original idea won't work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, when the service worker restarts, the user gets logged out. This PR is the extension portion of the login fix. More details will be added as we get further along.
More Information
Depends on:
Manual Testing Steps
yarn start:mv3Pre-Merge Checklist
+ If there are functional changes: