feat: Bump @metamask/providers to ^20.0.0
#29936
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| export enum NOTIFICATION_NAMES { | ||
| accountsChanged = 'metamask_accountsChanged', | ||
| chainChanged = 'metamask_chainChanged', | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2742,6 +2742,10 @@ export default class MetamaskController extends EventEmitter { | |
| if (chains.length > 0 && !chains.includes(currentChainIdForOrigin)) { | ||
| const networkClientId = | ||
| this.networkController.findNetworkClientIdByChainId(chains[0]); | ||
| // setActiveNetwork should be called before setNetworkClientIdForDomain | ||
| // to ensure that the isConnected value can be accurately inferred from | ||
| // NetworkController.state.networksMetadata in return value of | ||
| // `metamask_getProviderState` requests and `metamask_chainChanged` events. | ||
| this.networkController.setActiveNetwork(networkClientId); | ||
| this.selectedNetworkController.setNetworkClientIdForDomain( | ||
| origin, | ||
|
|
@@ -2993,7 +2997,11 @@ export default class MetamaskController extends EventEmitter { | |
| const providerNetworkState = await this.getProviderNetworkState(origin); | ||
|
|
||
| return { | ||
| /** | ||
| * We default `isUnlocked` to `true` because even though we no longer emit events depending on this, | ||
| * embedded dapp providers might listen directly to our streams, and therefore depend on it, so we leave it here. | ||
| */ | ||
| isUnlocked: true, | ||
ffmcgee725 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| accounts: this.getPermittedAccounts(origin), | ||
| ...providerNetworkState, | ||
| }; | ||
|
|
@@ -6495,20 +6503,8 @@ export default class MetamaskController extends EventEmitter { | |
|
|
||
| /** | ||
| * Handle global application unlock. | ||
| */ | ||
| _onUnlock() { | ||
|
Member
There was a problem hiding this comment. Hmm. There might still be a case where a dapp doesn't find out about an account change: when the accounts change before the wallet is marked as unlocked (e.g. if a change is triggered during that update, not sure exactly what the sequence of events is). I see that we react to account changes below in this file, in Maybe we can continue emitting them here, or remove that
Member
There was a problem hiding this comment. resolved in 7be8143 by removing |
||
| this.unMarkPasswordForgotten(); | ||
|
|
||
| // In the current implementation, this handler is triggered by a | ||
|
|
@@ -6519,16 +6515,8 @@ export default class MetamaskController extends EventEmitter { | |
|
|
||
| /** | ||
| * Handle global application lock. | ||
| */ | ||
| _onLock() { | ||
| // In the current implementation, this handler is triggered by a | ||
| // KeyringController event. Other controllers subscribe to the 'lock' | ||
| // event of the MetaMaskController itself. | ||
|
|
@@ -7057,21 +7045,19 @@ export default class MetamaskController extends EventEmitter { | |
| } | ||
|
|
||
| _notifyAccountsChange(origin, newAccounts) { | ||
| this.notifyConnections(origin, { | ||
| method: NOTIFICATION_NAMES.accountsChanged, | ||
| // This should be the same as the return value of `eth_accounts`, | ||
| // namely an array of the current / most recently selected Ethereum | ||
| // account. | ||
| params: | ||
| newAccounts.length < 2 | ||
| ? // If the length is 1 or 0, the accounts are sorted by definition. | ||
| newAccounts | ||
| : // If the length is 2 or greater, we have to execute | ||
| // `eth_accounts` vi this method. | ||
| this.getPermittedAccounts(origin), | ||
| }); | ||
|
|
||
| this.permissionLogController.updateAccountsHistory(origin, newAccounts); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.