Build - unify build process #6276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
kumavis
force-pushed
the
build-improvements
branch
from
8044f49 to
02ae983
Compare
Collaborator
Member
Author
|
edit: fixed it keep getting stuck in this weird dep resolution issue
|
kumavis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4540
Updates #5584
The goal of this PR is to unify our build configuration for production and tests.
The
mascaraandflattests use a special build system that differs from our normal build system. Divergence in the build systems can lead to false positives and false negatives. It also has prevented unification of our build configuration, specifically the browserify transforms.Some of the browserify transforms are defined in the gulpfile, while other transforms are defined in the
package.json"browserify" field.Major parts of this PR
Removes mascara tests and source. Mascara tests use a custom build system. Since we don't currently run these tests or maintain the mascara service, this is essentially dead code.
This PR Removes the flat tests. Flat tests use a custom build system. We currently run these tests and they have been updated occasionally in recent history. Removing these tests may be unnecessary! It may be possible to unify the build system. For the sake of quick development of this proposal, they have been removed.
Transforms from
package.jsonhave been moved to the gulpfile with the other transforms. This unifies our build system.gets us up to date with babel ecosystem and new features like browserlist support + other platforms