chore: cp-7.51.0 faster address checksum (#16926) #17174

Cal-L · 2025-07-14T19:08:44Z

Description

This PR is originally from @Nodonisko from Margelo

This PR uses new faster memoized functions for working with address checksum.

There is already significant boost in AccountList performance and it should be even better when MetaMask/core#6054 is released and also when we fix Blockies Avatars.

Related issues

Fixes: #15560

Manual testing steps

Open Account List
It should feel faster than before

Screenshots/Recordings

Before

You can set that before then was lot of interrupted work before Account List modal is even displayed. It takes around ~7s from click to modal to be actually visible.

After

Here it takes only around ~3s to mount. (still slow but much better than before)

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding
Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** This PR uses new faster memoized functions for working with address checksum. There is already significant boost in AccountList performance and it should be even better when MetaMask/core#6054 is released and also when we fix Blockies Avatars. ## **Related issues** Fixes: #15560 ## **Manual testing steps** 1. Open Account List 2. It should feel faster than before ## **Screenshots/Recordings**  ### **Before** You can set that before then was lot of interrupted work before Account List modal is even displayed. It takes around ~7s from click to modal to be actually visible. <img width="1324" alt="Screenshot 2025-07-03 at 21 36 06" src="https://github.com/user-attachments/assets/7c624f31-db84-4ade-9df6-a116bff9a68f" /> ### **After** Here it takes only around ~3s to mount. (still slow but much better than before) <img width="1325" alt="Screenshot 2025-07-03 at 21 38 16" src="https://github.com/user-attachments/assets/96a5a4f1-59b7-4cfa-b58c-ac84eb238654" /> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-14T19:08:56Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-07-14T19:09:40Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7fae5e5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f463a46d-66f1-46b9-866e-93668548e547

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L · 2025-07-17T19:59:48Z

No need to re-run e2e since merged conflicts from main and e2e passed before

cursor

Bug: Null Safety and Address Formatting Issues

The commit unconditionally calls toFormattedAddress with selectedAddress, which can be null or undefined, removing the prior null-safety fallback. This may cause runtime errors or unexpected behavior. Furthermore, replacing the !isNonEvmAddress check with toFormattedAddress changes the address formatting logic, potentially leading to incorrect formatting for non-EVM addresses and breaking balance lookups.

app/selectors/earnController/earn/index.ts#L192-L200

metamask-mobile/app/selectors/earnController/earn/index.ts

Lines 192 to 200 in d7dc614

    
           // TODO: balance logic, extract to utils then use when we are clear to add token 
        
           const formattedAddress = toFormattedAddress(selectedAddress as Hex); 
        
           const rawAccountBalance = selectedAddress 
        
             ? accountsByChainId[token?.chainId as Hex]?.[formattedAddress]?.balance 
        
             : '0'; 
        
           const rawStakedAccountBalance = selectedAddress 
        
             ? accountsByChainId[token?.chainId as Hex]?.[formattedAddress] 
        
                 ?.stakedBalance 
        
             : '0';

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

sonarqubecloud · 2025-07-17T20:15:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbot · 2025-09-03T09:07:43Z

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

Cal-L requested review from a team as code owners July 14, 2025 19:08

metamaskbot added the team-mobile-platform Mobile Platform team label Jul 14, 2025

Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no changelog required No changelog entry is required for this change labels Jul 14, 2025

github-project-automation bot moved this to Needs dev review in PR review queue Jul 14, 2025

github-project-automation bot added this to PR review queue Jul 14, 2025

Cal-L added the Run Smoke E2E label Jul 14, 2025

metamaskbot added the bitrise-result-ready label Jul 14, 2025

github-actions bot removed the bitrise-result-ready label Jul 14, 2025

matthewwalsh0 previously approved these changes Jul 15, 2025

View reviewed changes

brianacnguyen previously approved these changes Jul 16, 2025

View reviewed changes

vinnyhoward previously approved these changes Jul 17, 2025

View reviewed changes

infiniteflower previously approved these changes Jul 17, 2025

View reviewed changes

Cal-L enabled auto-merge July 17, 2025 18:41

Fix merge conflicts

d7dc614

Cal-L dismissed stale reviews from infiniteflower, vinnyhoward, brianacnguyen, and matthewwalsh0 via d7dc614 July 17, 2025 19:59

Cal-L added No E2E Smoke Needed and removed Run Smoke E2E labels Jul 17, 2025

nickewansmith approved these changes Jul 17, 2025

View reviewed changes

cursor bot reviewed Jul 17, 2025

View reviewed changes

vinnyhoward approved these changes Jul 17, 2025

View reviewed changes

brianacnguyen approved these changes Jul 17, 2025

View reviewed changes

micaelae approved these changes Jul 18, 2025

View reviewed changes

infiniteflower approved these changes Jul 18, 2025

View reviewed changes

Nodonisko approved these changes Jul 21, 2025

View reviewed changes

vinistevam approved these changes Jul 22, 2025

View reviewed changes

Cal-L added this pull request to the merge queue Jul 22, 2025

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jul 22, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025

OGPoyraz approved these changes Jul 22, 2025

View reviewed changes

Cal-L added this pull request to the merge queue Jul 22, 2025

owencraston approved these changes Jul 22, 2025

View reviewed changes

Merged via the queue into main with commit 55bc8a6 Jul 22, 2025
53 checks passed

Cal-L deleted the margelo/faster-address-checksum branch July 22, 2025 16:12

github-actions bot locked and limited conversation to collaborators Jul 22, 2025

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 22, 2025

metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 22, 2025

metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: cp-7.51.0 faster address checksum (#16926) #17174

chore: cp-7.51.0 faster address checksum (#16926) #17174

Uh oh!

Cal-L commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 14, 2025 •

edited by metamaskbot

Loading

Uh oh!

Cal-L commented Jul 17, 2025

Uh oh!

cursor bot left a comment

Uh oh!

sonarqubecloud bot commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

	// TODO: balance logic, extract to utils then use when we are clear to add token
	const formattedAddress = toFormattedAddress(selectedAddress as Hex);
	const rawAccountBalance = selectedAddress
	? accountsByChainId[token?.chainId as Hex]?.[formattedAddress]?.balance
	: '0';
	const rawStakedAccountBalance = selectedAddress
	? accountsByChainId[token?.chainId as Hex]?.[formattedAddress]
	?.stakedBalance
	: '0';

Uh oh!

chore: cp-7.51.0 faster address checksum (#16926) #17174

chore: cp-7.51.0 faster address checksum (#16926) #17174

Uh oh!

Conversation

Cal-L commented Jul 14, 2025

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jul 14, 2025

Uh oh!

github-actions bot commented Jul 14, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Cal-L commented Jul 17, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Null Safety and Address Formatting Issues

Uh oh!

sonarqubecloud bot commented Jul 17, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

github-actions bot commented Jul 14, 2025 •

edited by metamaskbot

Loading