-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: integrate @metamask/gator-permissions-controller #20006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integrate @metamask/gator-permissions-controller #20006
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
4af4ae6 to
2ba8151
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA |
09bb79b to
025a5a6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20006 +/- ##
==========================================
- Coverage 76.60% 76.53% -0.08%
==========================================
Files 3315 3317 +2
Lines 80545 80634 +89
Branches 14693 14720 +27
==========================================
+ Hits 61704 61712 +8
- Misses 14793 14870 +77
- Partials 4048 4052 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
025a5a6 to
4b44253
Compare
44e4b22 to
e4f482a
Compare
…t do anything, but it must be in place when the SignatureController is updated
…ller-init.test.ts to babel exclude list for transforming env vars
e4f482a to
c2abce6
Compare
.../messengers/gator-permissions-controller-messenger/gator-permissions-controller-messenger.ts
Show resolved
Hide resolved
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
|
sethkfman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



Description
This PR adds @metamask/gator-permissions-controller@0.2.0 as a dependency and initializes the controller. Although the controller doesn't do anything in mobile build yet, it is a dependency of the as-yet-unreleased @metamask/signature-controller@34.0.0.
Changelog
No end-user-facing changes, as this is simply pre-empting the dependency for @metamask/signature-controller.
Manual testing steps
No behavioural change - Ensure MetaMask mobile initializes without errors.
This change has been validated against MetaMask Android. Successfully onboarded a new wallet via SRP.
Pre-merge author checklist
Pre-merge reviewer checklist