Skip to content

Conversation

@jeffsmale90
Copy link
Contributor

@jeffsmale90 jeffsmale90 commented Sep 18, 2025

Description

This PR adds @metamask/gator-permissions-controller@0.2.0 as a dependency and initializes the controller. Although the controller doesn't do anything in mobile build yet, it is a dependency of the as-yet-unreleased @metamask/signature-controller@34.0.0.

Changelog

No end-user-facing changes, as this is simply pre-empting the dependency for @metamask/signature-controller.

Manual testing steps

No behavioural change - Ensure MetaMask mobile initializes without errors.

This change has been validated against MetaMask Android. Successfully onboarded a new wallet via SRP.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jeffsmale90 jeffsmale90 force-pushed the feat/integrate-gator-permissions-controller branch 2 times, most recently from 4af4ae6 to 2ba8151 Compare September 19, 2025 04:41
@socket-security
Copy link

socket-security bot commented Sep 19, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​metamask/​7715-permission-types@​0.3.0691006992100
Addednpm/​@​metamask/​delegation-core@​0.2.0751009992100
Addednpm/​@​metamask/​delegation-deployments@​0.12.0961007785100
Addednpm/​@​metamask/​gator-permissions-controller@​0.2.0971008390100

View full report

@jeffsmale90 jeffsmale90 changed the title Integrate @metamask/gator-permissions-controller. Presently it doesn'… Integrate @metamask/gator-permissions-controller Sep 19, 2025
@jeffsmale90
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jeffsmale90 jeffsmale90 force-pushed the feat/integrate-gator-permissions-controller branch 2 times, most recently from 09bb79b to 025a5a6 Compare September 21, 2025 21:37
@jeffsmale90 jeffsmale90 changed the title Integrate @metamask/gator-permissions-controller chore: integrate @metamask/gator-permissions-controller Sep 21, 2025
@jeffsmale90 jeffsmale90 added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Sep 21, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 21, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.53%. Comparing base (2c14166) to head (025a5a6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20006      +/-   ##
==========================================
- Coverage   76.60%   76.53%   -0.08%     
==========================================
  Files        3315     3317       +2     
  Lines       80545    80634      +89     
  Branches    14693    14720      +27     
==========================================
+ Hits        61704    61712       +8     
- Misses      14793    14870      +77     
- Partials     4048     4052       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeffsmale90 jeffsmale90 force-pushed the feat/integrate-gator-permissions-controller branch from 025a5a6 to 4b44253 Compare September 21, 2025 22:18
@jeffsmale90 jeffsmale90 added the team-delegation MetaMask Delegation Team label Sep 21, 2025
@jeffsmale90 jeffsmale90 force-pushed the feat/integrate-gator-permissions-controller branch 5 times, most recently from 44e4b22 to e4f482a Compare September 22, 2025 03:00
…t do anything, but it must be in place when the SignatureController is updated
…ller-init.test.ts to babel exclude list for transforming env vars
@jeffsmale90 jeffsmale90 force-pushed the feat/integrate-gator-permissions-controller branch from e4f482a to c2abce6 Compare September 22, 2025 03:27
@jeffsmale90 jeffsmale90 marked this pull request as ready for review September 22, 2025 04:17
@jeffsmale90 jeffsmale90 requested a review from a team as a code owner September 22, 2025 04:17
cursor[bot]

This comment was marked as outdated.

Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
@sonarqubecloud
Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffsmale90 jeffsmale90 added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit b195d91 Sep 22, 2025
119 of 120 checks passed
@jeffsmale90 jeffsmale90 deleted the feat/integrate-gator-permissions-controller branch September 22, 2025 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
@metamaskbot metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Sep 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-M team-delegation MetaMask Delegation Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants