Skip to content

Conversation

@baptiste-marchand
Copy link
Contributor

@baptiste-marchand baptiste-marchand commented Dec 9, 2025

Following MetaMask/metamask-extension#38466 :

  • Bump @metamask/tron-wallet-snap to v1.15.1
  • Bump @metamask/keyring-api to v21.3.0

This PR is required before enabling Tron dApp connectivity support.

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates TRX transaction signing check to TrxMethod.SignMessage and bumps @metamask/keyring-api and @metamask/tron-wallet-snap versions.

  • Selectors:
    • Update selectCanSignTransactions to check TrxMethod.SignMessage (replacing SignMessageV2).
  • Tests:
    • Adjust accountsController.test.ts to use TRX Account with SignMessage and TrxMethod.SignMessage.
  • Dependencies:
    • Bump @metamask/keyring-api to ^21.3.0.
    • Bump @metamask/tron-wallet-snap to ^1.15.1.
    • Update yarn.lock accordingly.

Written by Cursor Bugbot for commit f974db8. This will update automatically on new commits. Configure here.

@baptiste-marchand baptiste-marchand added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-wallet-standard Team responsible of the MetaMask Wallet Standard implementation label Dec 9, 2025
@baptiste-marchand baptiste-marchand changed the title chore: update @metamask/keyring-api and @metamask/tron-wallet-snap ve… chore: update @metamask/keyring-api and @metamask/tron-wallet-snap versions Dec 9, 2025
@socket-security
Copy link

socket-security bot commented Dec 9, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​tron-wallet-snap@​1.13.0 ⏵ 1.15.1100 +110079 +198 +1100
Updatednpm/​@​metamask/​keyring-api@​21.2.0 ⏵ 21.3.0100 +110010097 +150

View full report

@baptiste-marchand baptiste-marchand added the No QA Needed Apply this label when your PR does not need any QA effort. label Dec 9, 2025
@github-actions github-actions bot added size-S and removed size-XS labels Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeTrade, SmokeNetworkExpansion, SmokeStake
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

The changes involve:

  1. Tron Method Rename: The selector selectCanSignTransactions has been updated from TrxMethod.SignMessageV2 to TrxMethod.SignMessage. This aligns with a change in the Tron wallet snap API.

  2. Package Updates:

    • @metamask/keyring-api upgraded from 21.2.0 to 21.3.0
    • @metamask/tron-wallet-snap upgraded from 1.13.0 to 1.15.1

The selectCanSignTransactions selector is used in:

  • Bridge functionality (app/core/redux/slices/bridge/index.ts) - affects whether swaps/bridge are enabled
  • Multi-chain account management components

Impact areas:

  • SmokeAccounts: The selector is core to account management and determines if accounts can sign transactions. This is critical for account functionality.
  • SmokeTrade: The selector affects selectIsSwapsEnabled in the bridge slice, directly impacting swap/trade functionality.
  • SmokeNetworkExpansion: Tron is a non-EVM chain, so changes to Tron support fall under network expansion testing.
  • SmokeStake: The Tron wallet snap is used for Tron staking functionality (as seen in the useTronStake hooks).

The risk is medium because:

  • The change is narrow (single method rename) but touches critical transaction signing capability detection
  • Package updates could introduce behavioral changes
  • The code path is used by bridge/swap functionality which is financially sensitive
  • However, the change appears to be a straightforward API alignment with the updated packages

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@baptiste-marchand baptiste-marchand added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 94bc787 Dec 9, 2025
91 checks passed
@baptiste-marchand baptiste-marchand deleted the chore/update-keyring-api-and-tron-wallet-snap branch December 9, 2025 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-S team-wallet-standard Team responsible of the MetaMask Wallet Standard implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants