Skip to content

Conversation

@metamaskbot
Copy link
Collaborator

@metamaskbot metamaskbot commented Dec 17, 2025

Note

Updates and expands German translations across the app.

  • Overhauls locales/languages/de.json with many revised strings, added keys (e.g., short sort labels, "trade_again", "learn_more"), and normalized terms (e.g., Mid, Ask, Bid)
  • Touches numerous surfaces: settings, notifications, token/NFT management, swaps/bridge, staking/earn, fiat on-ramp/region flows, perps, transaction details, backup flows, card onboarding/auth, and rewards
  • Scope is copy-only; primary risk is UI text regressions or layout/fit issues in German

Written by Cursor Bugbot for commit fa876c3. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Dec 17, 2025
@github-actions github-actions bot added size-XL and removed size-XS labels Dec 17, 2025
@metamaskbot metamaskbot force-pushed the l10n_crowdin_action branch 5 times, most recently from 89db569 to 2d6f3ee Compare December 17, 2025 09:09
@metamaskbot metamaskbot force-pushed the l10n_crowdin_action branch 2 times, most recently from 90f6339 to 5090855 Compare December 17, 2025 09:43
"tokens_hidden_desc": "Gefundene Tokens in Ihrer Wallet verborgen",
"token_hidden_title": "Token wird verborgen",
"token_hidden_title": "Hiding token",
"token_hidden_desc": "{{tokenSymbol}} verborgen"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Translations reverted to English across multiple languages

The PR title indicates "New Crowdin translations" but the actual changes replace existing localized strings with English text across German, Greek, Spanish, French, Hindi, and Indonesian locales. Strings like tokens_imported_title, tokens_hidden_title, hide_token.title, all_networks, refresh_metadata, and many others in settings and asset sections are being reverted from their translated versions to English. This appears to be an unintended translation regression that will cause affected users to see English text instead of their localized content.

Additional Locations (2)

Fix in Cursor Fix in Web

@metamaskbot metamaskbot force-pushed the l10n_crowdin_action branch 9 times, most recently from 6d1d5b2 to e4dde61 Compare December 17, 2025 13:39
"current_network": "Aktuelles Netzwerk",
"popular_networks": "Beliebte Netzwerke",
"all_networks": "Alle Netzwerke",
"all_networks": "All networks",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Translations replaced with English text across multiple locales

This PR systematically replaces existing localized translations with English text across German, Greek, Spanish, French, Hindi, and Indonesian locale files. Dozens of properly translated strings like "tokens_imported_title": "Importierte Tokens" (German), "all_networks": "Alle Netzwerke" (German), "current_language": "Idioma actual" (Spanish) are being overwritten with their English equivalents. This is a localization regression that would cause non-English users to see English text where they previously saw their native language translations, degrading the internationalized user experience.

Additional Locations (2)

Fix in Cursor Fix in Web

@metamaskbot metamaskbot force-pushed the l10n_crowdin_action branch 3 times, most recently from d26b6a9 to f87265b Compare December 17, 2025 15:28
"current_network": "Aktuelles Netzwerk",
"popular_networks": "Beliebte Netzwerke",
"all_networks": "Alle Netzwerke",
"all_networks": "All networks",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English in locale file

The German locale file (de.json) has many existing German translations being replaced with English strings. This is a translation regression that affects German-speaking users. For example, tokens_imported_title changed from "Importierte Tokens" to "Imported tokens", current_language from "Aktuelle Sprache" to "Current language", reset_account from "Konto zurücksetzen" to "Reset account", and many other UI strings throughout the file. This appears to be a Crowdin sync issue causing German translations to be lost.

Additional Locations (2)

Fix in Cursor Fix in Web

},
"hide_token": {
"title": "Token verbergen?",
"title": "Hide token?",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English text throughout locale file

The German locale file de.json has many existing German translations being replaced with English text. Examples include "Aktuelle Sprache" → "Current language", "Konto zurücksetzen" → "Reset account", "Token verbergen?" → "Hide token?", "Alle Netzwerke" → "All networks", "Statuslogs" → "State logs", and dozens more throughout the file. This causes German users to see English UI text instead of their native language, breaking the localization experience. This appears to affect a significant portion of the translation strings across settings, wallet, token management, and other UI areas.

Additional Locations (2)

Fix in Cursor Fix in Web

},
"hide_token": {
"title": "Token verbergen?",
"title": "Hide token?",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English text

Multiple German translations are being replaced with English text throughout the file. For example, tokens_imported_title changes from "Importierte Tokens" to "Imported tokens", hide_token.title changes from "Token verbergen?" to "Hide token?", and current_language changes from "Aktuelle Sprache" to "Current language". This pattern affects dozens of strings across the file (settings, token management, notifications, etc.). German-speaking users would see English text where they previously saw German translations, degrading the localization experience.

Additional Locations (2)

Fix in Cursor Fix in Web

"Geheime Wiederherstellungsphrase",
"gibt",
"vollen Zugriff auf Ihr Wallet, Ihr Guthaben und Ihre Konten.\n\n",
"full access to your wallet, funds and accounts.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed German/English in composed sentence array

The seed_phrase_explanation array elements are combined to form a sentence. Element at index 3 was changed from German ("vollen Zugriff auf Ihr Wallet, Ihr Guthaben und Ihre Konten.") to English ("full access to your wallet, funds and accounts.") while surrounding elements remain in German. This creates a grammatically broken mixed-language sentence for German users: "Ihr/e Geheime Wiederherstellungsphrase gibt full access to your wallet, funds and accounts. MetaMask ist eine..."

Fix in Cursor Fix in Web

},
"hide_token": {
"title": "Token verbergen?",
"title": "Hide token?",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English text

Many German translations in de.json are being replaced with English text, causing a localization regression. Strings like tokens_imported_title ("Importierte Tokens" → "Imported tokens"), current_language ("Aktuelle Sprache" → "Current language"), search_engine ("Suchmaschine" → "Search engine"), and over 100 others are now showing English instead of German. German-speaking users will see English text throughout the app where they previously saw proper translations.

Additional Locations (2)

Fix in Cursor Fix in Web

"title": "Einstellungen",
"current_conversion": "Basiswährung",
"current_language": "Aktuelle Sprache",
"current_language": "Current language",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations reverted to English throughout locale file

This Crowdin translation update replaces many existing German translations with English text, breaking localization for German users. Examples include current_language changing from "Aktuelle Sprache" to "Current language", search_engine from "Suchmaschine" to "Search engine", reset_account from "Konto zurücksetzen" to "Reset account", and dozens of similar regressions throughout the file. German users will see English text where localized text previously existed, significantly degrading the user experience.

Additional Locations (2)

Fix in Cursor Fix in Web

"current_network": "Aktuelles Netzwerk",
"popular_networks": "Beliebte Netzwerke",
"all_networks": "Alle Netzwerke",
"all_networks": "All networks",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English text in locale file

Many German translations in de.json are being replaced with English text, which degrades the localization experience for German-speaking users. For example, "tokens_imported_title" changed from "Importierte Tokens" to "Imported tokens", and "all_networks" changed from "Alle Netzwerke" to "All networks". The same file still contains German translations for other strings, creating an inconsistent UI where some text appears in German and some in English. This appears to be an unintended regression from the Crowdin sync process affecting over 100 translation strings throughout the file.

Additional Locations (2)

Fix in Cursor Fix in Web

@metamaskbot metamaskbot force-pushed the l10n_crowdin_action branch 4 times, most recently from 4ee1d84 to 3a45e18 Compare December 30, 2025 12:11
"current_network": "Aktuelles Netzwerk",
"popular_networks": "Beliebte Netzwerke",
"all_networks": "Alle Netzwerke",
"all_networks": "All networks",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English strings in locale

The German locale file (de.json) has numerous existing German translations being replaced with English strings. Examples include "Importierte Tokens" becoming "Imported tokens", "Alle Netzwerke" becoming "All networks", "Aktuelle Sprache" becoming "Current language", and many others throughout the file. This translation regression would cause German-speaking users to see English text in many parts of the application where they previously saw German. This appears to be an unintended sync issue with Crowdin that reverts localized content to the source English strings.

Additional Locations (2)

Fix in Cursor Fix in Web

@metamaskbot metamaskbot force-pushed the l10n_crowdin_action branch 2 times, most recently from 3c815b2 to c68d5d6 Compare December 31, 2025 12:11
"tokens_hidden_title": "Hiding tokens",
"tokens_hidden_desc": "Gefundene Tokens in Ihrer Wallet verborgen",
"token_hidden_title": "Token wird verborgen",
"token_hidden_title": "Hiding token",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English text

The German locale file (de.json) has numerous properly translated German strings being replaced with English text. For example, "tokens_imported_title" changed from "Importierte Tokens" to "Imported tokens", "hide_token.title" from "Token verbergen?" to "Hide token?", and "current_language" from "Aktuelle Sprache" to "Current language". This affects hundreds of UI strings throughout the file and will cause German-speaking users to see English text where they expect German translations, breaking the localization experience.

Additional Locations (2)

Fix in Cursor Fix in Web

},
"hide_token": {
"title": "Token verbergen?",
"title": "Hide token?",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English text in locale file

The German locale file (de.json) has many properly translated German strings being replaced with English text. For example, "Importierte Tokens" becomes "Imported tokens", "Token verbergen?" becomes "Hide token?", "Alle Netzwerke" becomes "All networks", "Aktuelle Sprache" becomes "Current language", and dozens more throughout the file. This appears to be a translation regression that would cause German-speaking users to see English text instead of their native language translations.

Additional Locations (2)

Fix in Cursor Fix in Web

@metamaskbot metamaskbot force-pushed the l10n_crowdin_action branch 2 times, most recently from 7528bce to 4ca4f13 Compare January 2, 2026 00:28
},
"hide_token": {
"title": "Token verbergen?",
"title": "Hide token?",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German translations replaced with English text in localization file

The German translation file (de.json) has many existing German translations being replaced with English text. For example, tokens_imported_title changed from "Importierte Tokens" to "Imported tokens", hide_token.title changed from "Token verbergen?" to "Hide token?", all_networks changed from "Alle Netzwerke" to "All networks", and dozens of similar regressions throughout the file. This defeats the purpose of localization and would cause German-speaking users to see English text where they previously saw German translations. This appears to be a sync issue with the Crowdin translation platform.

Additional Locations (2)

Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

The changes in this PR are exclusively localization/translation updates across 14 language JSON files (de.json, el.json, es.json, fr.json, hi.json, id.json, ja.json, ko.json, pt.json, ru.json, tl.json, tr.json, vi.json, zh.json).

After examining the diffs for multiple files (de.json, es.json, fr.json, ja.json, zh.json), I confirmed that all changes are:

  1. New translation keys: Adding new strings like mid_price, volume_short, funding_rate_short, open_interest_short, trade_again, and learn_more for the perpetuals trading feature.

  2. Translation text updates: Many existing translations are being standardized - some localized text is being changed to English strings (likely for consistency or because translations weren't ready), and some translations are being refined.

  3. No functional code changes: These are purely JSON files containing key-value pairs for UI text. No application logic, controllers, or core functionality is modified.

These localization changes:

  • Do not affect any application behavior or logic
  • Do not modify any critical paths (controllers, Engine, core modules)
  • Are purely cosmetic/text changes that affect what users see in different languages
  • Cannot introduce functional regressions

No E2E tests are needed because:

  • The changes cannot break any functionality
  • E2E tests verify functional behavior, not translation accuracy
  • Translation verification is typically done through manual review or specialized i18n testing tools, not E2E tests

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-XL team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants