test: Fix flaky GasFeeToken e2e test via 7702

[vinistevam]

Description

This Pr aims to fix the flakiness for e2e/specs/confirmations-redesigned/transactions/gas-fee-tokens-eip-7702.spec.ts.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #24139

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Adds visibility checks and refactors token selection retrieval to stabilize the Gas Fee Token EIP-7702 e2e test, then re-enables it.

• E2E:
  • e2e/pages/Confirmation/GasFeeTokenModal.ts
    • Add visibility assertion for GAS_FEE_TOKEN_AMOUNT_FIAT before text check.
  • e2e/specs/confirmations-redesigned/transactions/gas-fee-tokens-eip-7702.spec.ts
    • Re-enable spec (remove skip).
    • Add getGasFeeTokenSelected() helper and use it to verify selected token label.
    • Assert modal header Select a token is visible before validations.
    • Minor refactor to reduce flakiness around element attribute reads.

^{Written by Cursor Bugbot for commit 1c2bb39. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeConfirmationsRedesigned
• Risk Level: low
• AI Confidence: 95%

click to see 🤖 AI reasoning details

The changes are purely E2E test infrastructure modifications:

1. GasFeeTokenModal.ts: Added a visibility assertion in the checkAmountFiat method to ensure the element is visible before getting its attributes. This is a defensive improvement to prevent flaky tests.

2. gas-fee-tokens-eip-7702.spec.ts:

   • Re-enabled a previously skipped test (changed describe.skip to describe)
   • Added a helper function getGasFeeTokenSelected() for code reuse
   • Added an assertion to verify the "Select a token" modal is visible
   • The test is explicitly tagged with SmokeConfirmationsRedesigned

Since no application code is changed, only E2E test code, the risk is low. However, since a previously skipped test is being re-enabled (it was skipped due to "app crashes on CI"), we should run the SmokeConfirmationsRedesigned tag to validate that the test now works correctly with the improvements made.

View GitHub Actions results

[cursor]

Bug: Helper function violates Page Object Model pattern (Bugbot Rules)

The getGasFeeTokenSelected() helper function performs element attribute access and parsing logic directly in the spec file. According to the E2E testing guidelines which state "Move all element selectors to Page Objects or dedicated selector files" and "Access UI elements through Page Object methods, not directly in test specs," this logic accessing RowComponents.NetworkFeeGasFeeTokenSymbol and calling getAttributes() should be encapsulated in a Page Object method (like RowComponents or a related page class) rather than defined in the test spec file.

 

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud