-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: convert advanced details bottom sheet into fullscreen #24174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: convert advanced details bottom sheet into fullscreen #24174
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
app/components/Views/ConfirmationsAdvancedDetails/ConfirmationsAdvancedDetails.test.tsx
Show resolved
Hide resolved
app/components/Views/ConfirmationsAdvancedDetails/ConfirmationsAdvancedDetails.test.tsx
Show resolved
Hide resolved
…thub.com:MetaMask/metamask-mobile into chore-mdp-307-send-flow-advanced-details-updates
app/components/Views/ConfirmationsAdvancedDetails/ConfirmationsAdvancedDetails.test.tsx
Show resolved
Hide resolved
app/components/Views/ConfirmationsAdvancedDetails/ConfirmationsAdvancedDetails.test.tsx
Show resolved
Hide resolved
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThis PR introduces a new ConfirmationsAdvancedDetails screen that refactors how advanced transaction details are displayed in the confirmations flow. The key changes are:
The changes are focused entirely on the confirmations UI/UX - specifically the redesigned confirmations flow. The functionality (viewing nonce, transaction data, interacting with address) remains the same, but the presentation changes from an expandable section to a full-screen view. Why SmokeConfirmationsRedesigned: This is the most appropriate tag because:
Risk Assessment: Medium risk because:
|
|
OGPoyraz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the PR @vinnyhoward ❤️
Let's discuss the design decisions before moving with the PR
Pull request was converted to draft



Description
Refactors the Send Flow advanced details UI by extracting inline expandable content into a dedicated full-screen view.
Component Refactor
AdvancedDetailsRow: Simplified from expandable accordion to navigation button
ConfirmationsAdvancedDetails: New full-screen component
Changelog
CHANGELOG entry:null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MDP-307
Manual testing steps
Screenshots/Recordings
Before
~After
~Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces the inline Advanced Details row with a dedicated full-screen
ConfirmationsAdvancedDetailsscreen and wires navigation, navbar, styles, routes, and tests.Views/ConfirmationsAdvancedDetailsscreen (UI, styles, nonce editing, tx data, batched tx rendering) and export viaindex.ts.Routes.FULL_SCREEN_CONFIRMATIONS.CONFIRMATIONS_ADVANCED_DETAILSand stack screen inMainNavigatorwith slide-in animation and transparent background.getConfirmationsAdvancedDetailsNavbarOptionsinUI/Navbar(back button, themed header); update related navbar tests.AdvancedDetailsRowwith a tappable row that navigates to the new full-screen screen; update styles and tests accordingly.Written by Cursor Bugbot for commit 62a578c. This will update automatically on new commits. Configure here.