Skip to content

Conversation

@vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Dec 18, 2025

Description

Refactors the Send Flow advanced details UI by extracting inline expandable content into a dedicated full-screen view.

Component Refactor

  • AdvancedDetailsRow: Simplified from expandable accordion to navigation button

    • Removed inline nonce editing, data display, and transaction details
    • Now navigates to dedicated advanced details screen
  • ConfirmationsAdvancedDetails: New full-screen component

    • Displays nonce with editing capability (respects Smart Transactions settings)
    • Shows transaction data with scroll support for long data
    • Displays "Interacting with" section (hidden for downgrade transactions)
    • Supports batched/nested transactions (7702 transactions)
    • Custom navbar with back navigation

Changelog

CHANGELOG entry:null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MDP-307

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

before after
before after

Before

~

After

~

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Replaces the inline Advanced Details row with a dedicated full-screen ConfirmationsAdvancedDetails screen and wires navigation, navbar, styles, routes, and tests.

  • Confirmations (Full-screen Advanced Details)
    • Add Views/ConfirmationsAdvancedDetails screen (UI, styles, nonce editing, tx data, batched tx rendering) and export via index.ts.
    • Register route Routes.FULL_SCREEN_CONFIRMATIONS.CONFIRMATIONS_ADVANCED_DETAILS and stack screen in MainNavigator with slide-in animation and transparent background.
    • Implement getConfirmationsAdvancedDetailsNavbarOptions in UI/Navbar (back button, themed header); update related navbar tests.
    • Replace expandable content in AdvancedDetailsRow with a tappable row that navigates to the new full-screen screen; update styles and tests accordingly.
  • Tests
    • Add comprehensive tests for the new screen (rendering, nonce modal, data scroll, batched tx, navbar updates).
    • Update snapshots and adjust confirmation info component tests to mock navigation where needed.
  • Misc
    • Minor style tweak: remove underline and use theme colors for nonce text.

Written by Cursor Bugbot for commit 62a578c. This will update automatically on new commits. Configure here.

@vinnyhoward vinnyhoward requested a review from a team as a code owner December 18, 2025 19:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Dec 18, 2025
…thub.com:MetaMask/metamask-mobile into chore-mdp-307-send-flow-advanced-details-updates
@github-actions github-actions bot added size-XL and removed size-L labels Dec 18, 2025
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmationsRedesigned
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

This PR introduces a new ConfirmationsAdvancedDetails screen that refactors how advanced transaction details are displayed in the confirmations flow. The key changes are:

  1. New Component: A new full-screen ConfirmationsAdvancedDetails view that displays transaction details (interacting with address, nonce, transaction data, nested transaction data for batched transactions)

  2. Navigation Refactor: The AdvancedDetailsRow component was changed from an expandable inline component to a touchable that navigates to the new full-screen view

  3. Route Addition: New route CONFIRMATIONS_ADVANCED_DETAILS added to the navigation stack

  4. Navbar Addition: New navbar options function for the advanced details screen

The changes are focused entirely on the confirmations UI/UX - specifically the redesigned confirmations flow. The functionality (viewing nonce, transaction data, interacting with address) remains the same, but the presentation changes from an expandable section to a full-screen view.

Why SmokeConfirmationsRedesigned: This is the most appropriate tag because:

  • All changed components are in the confirmations directory
  • The changes affect the redesigned confirmation UI components
  • The new screen is part of the FULL_SCREEN_CONFIRMATIONS route group
  • Test files updated are all confirmation-related tests

Risk Assessment: Medium risk because:

  • Navigation changes could affect user flow
  • The refactor changes how users interact with advanced details
  • Multiple confirmation types are affected (contract interactions, approvals, deployments, 7702 transactions)
  • However, the underlying functionality is preserved, just the presentation layer changed

View GitHub Actions results

@sonarqubecloud
Copy link

Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR @vinnyhoward ❤️
Let's discuss the design decisions before moving with the PR

@vinnyhoward vinnyhoward marked this pull request as draft December 19, 2025 18:45
auto-merge was automatically disabled December 19, 2025 18:45

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants