Skip to content

fix(perps): button flashing color on load #24180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abretonc7s wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

fix(perps): button flashing color on load #24180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions app/components/UI/Perps/Views/PerpsMarketDetailsView/PerpsMarketDetailsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ const PerpsMarketDetailsView: React.FC<PerpsMarketDetailsViewProps> = () => {
useState(false);
const [ohlcData, setOhlcData] = useState<OhlcData | null>(null);

// Track when position data has settled to avoid button flash (TAT-2236)
const [hasPositionSettled, setHasPositionSettled] = useState(false);

const { account } = usePerpsLiveAccount();

// Get real-time open orders via WebSocket
Expand Down Expand Up @@ -380,6 +383,19 @@ const PerpsMarketDetailsView: React.FC<PerpsMarketDetailsViewProps> = () => {
loadOnMount: true,
});

// Wait one frame after loading to avoid button flash (TAT-2236)
// This handles the gap between isLoadingPosition=false and existingPosition being populated
useEffect(() => {
if (isLoadingPosition) {
setHasPositionSettled(false);
} else {
const frame = requestAnimationFrame(() => {
setHasPositionSettled(true);
});
return () => cancelAnimationFrame(frame);
}
}, [isLoadingPosition]);

// Fetch order fills to get position opened timestamp
const { orderFills } = usePerpsOrderFills({
skipInitialFetch: false,
Expand Down Expand Up @@ -861,8 +877,8 @@ const PerpsMarketDetailsView: React.FC<PerpsMarketDetailsViewProps> = () => {

// Determine if any action buttons will be visible
const hasLongShortButtons = useMemo(
() => !isLoadingPosition && !hasZeroBalance,
[isLoadingPosition, hasZeroBalance],
() => !isLoadingPosition && !hasZeroBalance && hasPositionSettled,
[isLoadingPosition, hasZeroBalance, hasPositionSettled],
);

const hasAddFundsButton = useMemo(
Expand Down
Loading