Skip to content

Conversation

@nickewansmith
Copy link
Contributor

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

nickewansmith and others added 30 commits December 16, 2025 23:34
…ction-to-convert-m-usd-in-the-asset-list-next-to-an-m-usd-entry-that-i-will-see-even-if-i-dont-have-any-m-usd-so-that-i-can-be-enticed-into-converting-some
…-a-call-to-action-to-convert-m-usd-in-the-asset-list-next-to-an-m-usd-entry-that-i-will-see-even-if-i-dont-have-any-m-usd-so-that-i-can-be-enticed-into-converting-some' into feat/musd-136-allow-all-tokens-to-be-converted-to-musd
…ared-when-navigating-away-from-conversion-screen
…ared-when-navigating-away-from-conversion-screen
…ared-when-navigating-away-from-conversion-screen
…nvert-m-usd-in-the-asset-list-next-to-an-m-usd-entry-that-i-will-see-even-if-i-dont-have-any-m-usd-so-that-i-can-be-enticed-into-converting-some' of https://github.com/MetaMask/metamask-mobile into nick/demo-build-earn-zpw
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 force-pushed the nick/demo-build-earn-zpw branch from dce0890 to 3ab68f8 Compare December 19, 2025 19:26
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeStake, SmokeConfirmationsRedesigned, SmokeAssets, SmokeWalletPlatform, SmokeCore
  • Risk Level: high
  • AI Confidence: 82%
click to see 🤖 AI reasoning details

This PR introduces significant new functionality for MUSD (MetaMask USD) conversion and lending features with changes across multiple critical areas:

  1. Critical Engine Changes: The earn-controller-init.ts modifies the EarnController initialization to use DEV environment, which is a core controller change.

  2. Token Selector Changes: Three critical token selectors (tokenListController.ts, tokenRatesController.ts, tokensController.ts) are modified to add fallback metadata for aTokens (Aave v3 MUSD). These selectors are used throughout the app for token display and pricing, affecting how tokens appear in the wallet.

  3. New Confirmation Flows: New confirmation components for lending deposits (LendingDepositInfo) and mUSD max conversion (MusdMaxConversionInfo) are added to the confirmations flow, requiring SmokeConfirmationsRedesigned testing.

  4. New UI Screens and Routes: A new MusdQuickConvertView screen is added with new navigation routes for quick convert and max conversion modal.

  5. Asset Details Changes: The AssetDetailsActions component changes the "Receive" button to a "Quick Convert" button for mUSD, which is a significant UX change.

  6. Feature Flag System: New feature flag selectors for quick convert, CTA tokens, and blocklist/allowlist are added, controlling the visibility of new features.

  7. Transaction Monitoring: New useEarnLendingTransactionStatus hook monitors lending transactions and adds tokens to wallet on confirmation.

The risk is HIGH because:

  • Core Engine controller is modified
  • Token selectors used across the app are changed
  • New confirmation flows are added
  • UI changes affect asset display and actions
  • Multiple new hooks and utilities are introduced

Selected tags cover:

  • SmokeStake: Core staking/earning functionality changes
  • SmokeConfirmationsRedesigned: New lending and mUSD confirmation flows
  • SmokeAssets: Token metadata fallbacks and display changes
  • SmokeWalletPlatform: Core wallet functionality with token selectors
  • SmokeCore: Engine controller changes and navigation updates

View GitHub Actions results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants