Skip to content

Conversation

@georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Dec 19, 2025

Description

This PR adds code ownership entries for the new ramps-controller related paths to ensure the Ramp team is properly assigned as reviewers for changes to these files:

  • app/core/Engine/controllers/ramps-controller
  • app/core/Engine/messengers/ramps-controller-messenger
  • app/core/Engine/messengers/ramps-service-messenger
  • app/selectors/rampsController

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-2945

Manual testing steps

N/A - CODEOWNERS file change only.

Screenshots/Recordings

N/A - No UI changes.

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds Ramps team ownership entries for ramps controller, messengers, and selector paths in CODEOWNERS.

  • CODEOWNERS:
    • Add Ramps team ownership for:
      • app/core/Engine/controllers/ramps-controller
      • app/core/Engine/messengers/ramps-controller-messenger
      • app/core/Engine/messengers/ramps-service-messenger
      • app/selectors/rampsController

Written by Cursor Bugbot for commit fdbb6f2. This will update automatically on new commits. Configure here.

@georgeweiler georgeweiler requested a review from a team as a code owner December 19, 2025 05:01
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Dec 19, 2025
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 98%
click to see 🤖 AI reasoning details

The only change in this PR is to the .github/CODEOWNERS file, which is a GitHub configuration file that determines code review ownership assignments. The changes consist of:

  1. Whitespace reformatting for existing Ramps team entries (alignment changes)
  2. Adding new CODEOWNERS entries for the Ramps team to cover additional paths related to ramps-controller, ramps-controller-messenger, ramps-service-messenger, and rampsController selectors

This is purely an administrative/organizational change that:

  • Does not modify any application code
  • Does not change any runtime behavior
  • Does not affect any tests or test infrastructure
  • Only impacts who gets assigned as reviewers for future PRs touching those paths

No E2E tests are necessary because there are no functional changes to the application that could be validated by tests.

View GitHub Actions results

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-XS team-ramp issues related to Ramp features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants