Skip to content

Conversation

@aganglada
Copy link
Contributor

@aganglada aganglada commented Dec 22, 2025

Description

Remove non-evm from import token network list

Changelog

CHANGELOG entry: fix: remove non-evm from import token network list

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Restricts the AddAsset network selector to EVM networks by always enabling displayEvmNetworksOnly on NetworkListBottomSheet.

Written by Cursor Bugbot for commit 46f4f70. This will update automatically on new commits. Configure here.

@aganglada aganglada self-assigned this Dec 22, 2025
@aganglada aganglada requested a review from a team as a code owner December 22, 2025 08:42
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAssets
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The change modifies the displayEvmNetworksOnly prop in the AddAsset component from a conditional value (assetType !== 'token') to always true. This means the network selector in the Add Asset flow will now always show only EVM networks, regardless of whether the user is adding a token or NFT.

This is a relatively minor UI behavior change that:

  1. Restricts network selection to EVM networks only when importing tokens (previously showed all networks including non-EVM)
  2. Has no effect on NFT/collectible import (was already EVM-only)

The change is straightforward and localized to the AddAsset view. The SmokeAssets tag is the most appropriate as it covers "Asset management and display, NFTs, token details, etc." which directly relates to the import token/NFT functionality being modified.

The risk is low because:

  • The change is a simple prop value change
  • It's a restriction (showing fewer options) rather than adding new functionality
  • The component already had logic to handle EVM-only filtering
  • No core wallet functionality or security-sensitive code is affected

View GitHub Actions results

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants