-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: add EAS production cert #24220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…on rc/production builds
…tamask-mobile into wsun/add-eas-production-cert
app.config.js
Outdated
| // - "production" and "rc" use their own certificates | ||
| // - all other environments (exp, dev, test, e2e, beta, etc.) fall back to "exp" | ||
| const OTA_ENV_SOURCE = process.env.METAMASK_ENVIRONMENT; | ||
| const OTA_ENV = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably cleaner to have an object that maps to the correct values instead. It'll make it a little easier to read and to manage in case environment requirements change
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsThe changes are purely build-time configuration changes for Expo OTA (Over-The-Air) updates:
These changes:
Since E2E tests verify runtime app behavior and these changes only affect the build/deployment pipeline for OTA updates, no E2E tests are necessary to validate these changes. |
|
Cal-L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



Description
Add RC and Production EAS certificates
Changelog
CHANGELOG entry: Added RC and Production EAS certificates
Related issues
Fixes: #23448
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces environment-driven OTA code signing and production channel support.
certs/production.certificate.pemandcerts/rc.certificate.pem; keepscerts/exp.certificate.pemapp.config.js: selectsupdates.codeSigningCertificateandcodeSigningMetadata.keyidviaMETAMASK_ENVIRONMENT(fallback toexp); removes hardcoded request headersscripts/update-expo-channel.js: addsproductiontoCONFIG_MAP; derives OTA env (production/rc/exp) and loads matching cert/keyid; writes code-signing certificate and metadata to Android (AndroidManifest.xml) and iOS (Expo.plist); continues setting channel, runtimeVersion, update URL, check policy, and launch waitWritten by Cursor Bugbot for commit 4edfcde. This will update automatically on new commits. Configure here.