Skip to content

Conversation

@chaoticgoodpanda
Copy link

@chaoticgoodpanda chaoticgoodpanda commented Dec 31, 2025

Description

Problem

For multi-outcome prediction markets (e.g., "What price will Bitcoin hit in 2025?"), the About tab was displaying:

  1. A vague event-level description
  2. The same rules template repeated for each outcome (only differing by threshold values)

This created a cluttered, repetitive UI that didn't match Polymarket's cleaner approach of showing rules once.

Solution

  • Show outcome rules once: Display the first outcome's description as representative rules (since all outcomes share the same rule template with different thresholds)
  • Skip event description for multi-outcome markets: Avoid duplication since the outcome rules contain the detailed information users need
  • Keep single-outcome markets unchanged: Still show the event description for context
  • Retain disclaimer: Link to Polymarket for complete resolution details

Changelog

CHANGELOG entry: Fixed prediction market About tab to show detailed outcome rules once instead of repeating them for each outcome

Related issues

Fixes: Prediction market rules display showing repetitive content

Manual testing steps

Feature: Prediction Market Rules Display

  Scenario: User views About tab for multi-outcome market
    Given user is viewing a multi-outcome prediction market (e.g., "What price will Bitcoin hit in 2025?")
    
    When user taps on the About tab
    Then user sees a single "Rules" section with detailed resolution criteria
    And user does NOT see the vague event description
    And user does NOT see rules repeated for each outcome
    And user sees a disclaimer with link to Polymarket for full rules

  Scenario: User views About tab for single-outcome market
    Given user is viewing a single-outcome prediction market (e.g., "Will X happen?")
    
    When user taps on the About tab
    Then user sees the event description
    And user sees the Rules section with outcome details
    And user sees a disclaimer with link to Polymarket

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Streamlines rules presentation and adds a reusable, collapsible rules UI.

  • New PredictOutcomeRules component with show/hide toggle; used in PredictMarketOutcome to display outcome.description
  • Revamps About tab: shows market stats, hides event description for multi-outcome markets, adds a single Rules section from the first outcome’s description, and a disclaimer card with “View full rules” linking to the Polymarket event page
  • Adds handleViewMarketOnPolymarket navigation (uses market.slug) alongside existing resolution docs link
  • Extensive tests for rules behavior and navigation in PredictMarketDetails.test.tsx and new PredictOutcomeRules.test.tsx
  • Adds i18n strings for rules/disclaimer/show-hide actions

Written by Cursor Bugbot for commit b70b07d. This will update automatically on new commits. Configure here.

…ctMarketDetails

- Introduced a new component, `PredictOutcomeRules`, to display outcome rules based on market descriptions.
- Updated `PredictMarketOutcome` to conditionally render `PredictOutcomeRules` when an outcome description is available.
- Enhanced `PredictMarketDetails` tests to verify the display of rules and navigation to the Polymarket event page when the "view rules" button is pressed.
- Added localization strings for rules and disclaimers in the English language JSON file.
…prove UI

- Modified the `renderAboutSection` to show the first outcome's description as the representative rules for multi-outcome markets, avoiding duplication of event descriptions.
- Updated test cases in `PredictMarketDetails.test.tsx` to reflect changes in rules display and ensure proper functionality.
- Adjusted localization strings to include new rules and disclaimer texts.
- Removed outdated comments and cleaned up the code for better readability.
@chaoticgoodpanda chaoticgoodpanda requested a review from a team as a code owner December 31, 2025 09:05
@github-actions
Copy link
Contributor

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@chaoticgoodpanda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant