feat: custom error classes #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdouardBougon
requested changes
Jun 2, 2025
Contributor
EdouardBougon
left a comment
EdouardBougon
left a comment
There was a problem hiding this comment.
There is some types error.
We can discuss about the code to move to multichain
baptiste-marchand
force-pushed
the
feat/custom-error-classes
branch
from
0b687f5 to
0ca8b22
Compare
baptiste-marchand
force-pushed
the
feat/custom-error-classes
branch
from
0ca8b22 to
798351d
Compare
baptiste-marchand
force-pushed
the
feat/custom-error-classes
branch
from
c0006af to
7d6325a
Compare
This reverts commit e024746.
EdouardBougon
approved these changes
Jun 24, 2025
| resolve(msg.data.result); | ||
| } | ||
| if (resolve) { | ||
| resolve(msg); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces custom error classes so that errors are correctly handed over from the Multichain API to the user of the Multichain API Client.
A necessary refactor was also introduced making the transport interface agnostic from the Multichain API