Skip to content

add substream name to ended guards #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanejonas merged 4 commits into from
Jun 1, 2021
Merged

add substream name to ended guards #22

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bdcec4
add substream name to ended guards
shanejonas Jun 1, 2021
6657f6a
Update src/ObjectMultiplex.ts
shanejonas Jun 1, 2021
222742f
Merge branch 'main' into add-error-substream-name
shanejonas Jun 1, 2021
85ed39f
fix linting issues with stream ended guards
shanejonas Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ObjectMultiplex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,16 @@ export class ObjectMultiplex extends Duplex {
createStream(name: string): Substream {
// guard stream against destroyed already
if (this.destroyed) {
throw new Error('ObjectMultiplex - parent stream already destroyed');
throw new Error(
`ObjectMultiplex - parent stream for name "${name}" already destroyed`,
);
}

// guard stream against ended already
if (this._readableState.ended || this._writableState.ended) {
throw new Error('ObjectMultiplex - parent stream already ended');
throw new Error(
`ObjectMultiplex - parent stream for name "${name}" already ended`,
);
}

// validate name
Expand Down