Skip to content

Conversation

@boneskull
Copy link
Contributor

@boneskull boneskull commented Oct 26, 2023

Trying to investigate the failure mentioned here. cc @legobeat

@boneskull boneskull requested a review from a team as a code owner October 26, 2023 18:13
@socket-security
Copy link

socket-security bot commented Oct 26, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@lavamoat/allow-scripts 3.0.0 filesystem, environment +82 4.76 MB naugtur

@socket-security
Copy link

socket-security bot commented Oct 26, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: json-parse-even-better-errors@3.0.0, @npmcli/node-gyp@3.0.0, are-we-there-yet@3.0.1, npmlog@6.0.2, read-cmd-shim@4.0.0, npm-normalize-package-bin@3.0.1, which@3.0.1, write-file-atomic@5.0.1, exponential-backoff@3.1.1, foreground-child@3.1.1, make-fetch-happen@11.1.1, minipass-fetch@3.0.4, @lavamoat/allow-scripts@3.0.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor

legobeat commented Nov 9, 2023

@SocketSecurity ignore @lavamoat/allow-scripts@3.0.0

install scripts ok

@legobeat
Copy link
Contributor

legobeat commented Nov 9, 2023

@SocketSecurity ignore foreground-child@3.1.1

shell access ok

@legobeat
Copy link
Contributor

legobeat commented Nov 9, 2023

@SocketSecurity ignore make-fetch-happen@11.1.1
@SocketSecurity ignore minipass-fetch@3.0.4

network access ok

@legobeat
Copy link
Contributor

legobeat commented Nov 9, 2023

@SocketSecurity ignore json-parse-even-better-errors@3.0.0
@SocketSecurity ignore @npmcli/node-gyp@3.0.0
@SocketSecurity ignore are-we-there-yet@3.0.1
@SocketSecurity ignore npmlog@6.0.2
@SocketSecurity ignore read-cmd-shim@4.0.0
@SocketSecurity ignore npm-normalize-package-bin@3.0.1
@SocketSecurity ignore which@3.0.1
@SocketSecurity ignore write-file-atomic@5.0.1
@SocketSecurity ignore exponential-backoff@3.1.1

new authors ok

@legobeat legobeat merged commit fc12733 into MetaMask:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants