Typescript migration changes for obj-multiplex #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiranjanaBinoy
commented
Dec 1, 2020
rekmarks
requested changes
Dec 2, 2020
Member
rekmarks
left a comment
rekmarks
left a comment
There was a problem hiding this comment.
Nice job! Here's one more request, in addition to the inline comments:
- Add an appropriate
LICENSEfile perpackage.json. You can just copy the file from a different repository. The copyright year should be 2020.
rekmarks
reviewed
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added comments regarding a few doubts I have while migrating.
Closes #8