Skip to content

Investigate divergence between local and CI linter. #98

@grypez

Description

@grypez

Linting passes on mine, too. This complaint appears to be CI-specific. Relevant bug here. I haven't investigated why the behavior diverges between local and CI.

The cause of the issue is that CommandLike<CommandMethod.Evaluate, string> appears in both Command and CommandReply, so the union type Command | CommandReply after substitution

| ...
| CommandLike<CommandMethod.Evaluate, string>
| ...
| CommandLike<CommandMethod.Evaluate, string>
| ...

appears to the CI-linter as a redundancy.

Given that these are called union types, I find it hard to be sympathetic to the complaint. We could alleviate it following the guidelines for discriminating union types by adding a field like reply: boolean to Command and CommandReply and flipping the switch between them. We should align the CI behavior with the local behavior in any case.

Originally posted by @grypez in #94 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingchoreNot a feature, not documentation, but something we still have to do.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions