Skip to content

Conversation

@grypez
Copy link
Contributor

@grypez grypez commented Oct 10, 2024

Refs: #123

Generalizes the @ocap/streams message channel module to use abstract postMessage, addListener and removeListener methods. This enables the existing message channel initialization routine to target web workers, not just iframes.

@grypez grypez marked this pull request as ready for review October 10, 2024 17:19
@grypez grypez requested a review from a team as a code owner October 10, 2024 17:19
@grypez grypez force-pushed the grypez/abstract-message-channel-init branch from 373bdbe to dc78c18 Compare October 10, 2024 17:43
@grypez grypez enabled auto-merge (squash) October 10, 2024 17:52
@grypez grypez force-pushed the grypez/abstract-message-channel-init branch from dc78c18 to 732004d Compare October 10, 2024 18:00
@grypez grypez force-pushed the grypez/abstract-message-channel-init branch from 732004d to 773957f Compare October 10, 2024 18:02
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grypez grypez merged commit 1af61f5 into main Oct 10, 2024
@grypez grypez deleted the grypez/abstract-message-channel-init branch October 10, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants