Update offscreen.ts #144
Merged
Update offscreen.ts #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
rekm/offscreen-changes
branch
from
11d04ae to
0f867c0
Compare
rekmarks
commented
Oct 10, 2024
| } | ||
| })(), | ||
| kernelWorker.receiveMessages(), | ||
| return undefined; |
Member
Author
There was a problem hiding this comment.
We trigger an ESLint rule without this.
rekmarks
commented
Oct 10, 2024
| await Promise.all([ | ||
| (async () => { | ||
| kernelWorker.receiveMessages(), | ||
| kernelInitKit.promise.then(async () => { |
Member
Author
There was a problem hiding this comment.
Now we only await the init promise once.
rekmarks
commented
Oct 10, 2024
Comment on lines
+104
to
+105
| logger.error('Received unexpected reply', message); | ||
| continue; |
Member
Author
There was a problem hiding this comment.
Was this downgrade in preparation for some future change? We never seem to hit this condition on your branch.
Contributor
There was a problem hiding this comment.
Yes, it's an artifact of a hypothetical era. Since the worker stream is typed and guarded we could just remove this check altogether.
rekmarks
commented
Oct 10, 2024
| { method: typeof KernelCommandMethod.InitKernel } | ||
| >['params'] | ||
| >(); | ||
| const kernelInitKit = makePromiseKit<void>(); |
Member
Author
There was a problem hiding this comment.
Nothing actually used the resolved value of this promise anyway.
grypez
merged commit 4113bec
into
grypez/move-kernel-to-dedicated-worker-with-message-channel
grypez
pushed a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.