Skip to content

Conversation

@sirtimid
Copy link
Contributor

@sirtimid sirtimid commented Oct 23, 2024

Closes #28

This PR demonstrates how the kernel can manage loading multiple vats, restarting, sending messages like Ping and terminating them. It adds the restartVat and terminateAllVats methods as they were missing. Basic tests have been included, and more comprehensive tests for the Kernel will be added in a future PR.

Screenshot 2024-10-23 at 15 43 16

It also removes the default vat logic, since the vat lifecycle run ends by terminating all vats, so we add one vat afterwards.

@sirtimid sirtimid requested a review from a team as a code owner October 23, 2024 13:42
@sirtimid sirtimid force-pushed the sirtimid/1-n+1-ocap-kernel branch 3 times, most recently from ccf0ae6 to 91e69ba Compare October 25, 2024 09:39
@sirtimid sirtimid changed the title feat: Load, reload, restart and terminate multiple vats feat: Launch, message, restart and terminate multiple vats Oct 25, 2024
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of things. Are you planning to do #183 after this? That would be great.

@sirtimid sirtimid force-pushed the sirtimid/1-n+1-ocap-kernel branch from 446eb3f to af05231 Compare October 28, 2024 13:27
@sirtimid
Copy link
Contributor Author

Looks good! Just a couple of things. Are you planning to do #183 after this? That would be great.

Yes, I've started working on #183 already

@sirtimid sirtimid requested a review from rekmarks October 28, 2024 13:28
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sirtimid sirtimid merged commit 8446cb1 into main Oct 28, 2024
@sirtimid sirtimid deleted the sirtimid/1-n+1-ocap-kernel branch October 28, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable 1 : n+1 ocap programming

3 participants