Skip to content

chore: Improve type linting flow #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirtimid merged 3 commits into from
Oct 24, 2024
Merged

chore: Improve type linting flow #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cd584a
Rename test:ts to lint and add it to workflow
sirtimid Oct 24, 2024
0da6984
Add yarn lint:ts to lint-staged
sirtimid Oct 24, 2024
70ad0cc
remove lint:ts from command
sirtimid Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,21 @@
"lint:eslint": "yarn eslint . --cache",
"lint:fix": "yarn constraints --fix && yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies:fix",
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path .gitignore",
"lint:ts": "yarn workspaces foreach --all --parallel --verbose run lint:ts",
"postinstall": "simple-git-hooks",
"prepack": "./scripts/prepack.sh",
"test": "yarn workspaces foreach --all --parallel --verbose run test",
"test:ts": "yarn workspaces foreach --all --parallel --verbose run test:ts",
"test:clean": "yarn workspaces foreach --all --parallel --verbose run test:clean && yarn test",
"test:verbose": "yarn workspaces foreach --all --parallel --verbose run test:verbose",
"why:batch": "./scripts/why-batch.sh"
},
"simple-git-hooks": {
"pre-commit": "yarn lint-staged && yarn test:ts && yarn dedupe --check"
"pre-commit": "yarn lint-staged && yarn dedupe --check"
},
"lint-staged": {
"*.{js,mjs,cjs,ts,mts,cts}": [
"eslint --fix"
"eslint --fix",
"bash -c 'yarn lint:ts'"
],
"!(CHANGELOG).{json,html,md,yml}": [
"prettier --write"
Expand Down
2 changes: 1 addition & 1 deletion packages/errors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
"lint:eslint": "eslint . --cache",
"lint:fix": "yarn constraints --fix && yarn lint:eslint --fix && yarn lint:misc --write",
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore",
"lint:ts": "tsc --project tsconfig.test.json --noEmit",
"publish:preview": "yarn npm publish --tag preview",
"test": "vitest run --config vitest.config.ts",
"test:ts": "tsc --project tsconfig.test.json --noEmit",
"test:clean": "yarn test --no-cache --coverage.clean",
"test:dev": "yarn test --coverage false",
"test:verbose": "yarn test --reporter verbose",
Expand Down
2 changes: 1 addition & 1 deletion packages/extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
"lint:eslint": "eslint . --cache",
"lint:fix": "yarn constraints --fix && yarn lint:eslint --fix && yarn lint:misc --write",
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore",
"lint:ts": "tsc --project tsconfig.test.json --noEmit",
"publish:preview": "yarn npm publish --tag preview",
"start": "yarn build:vite:dev --watch",
"test": "vitest run --config vitest.config.ts",
"test:ts": "tsc --project tsconfig.test.json --noEmit",
"test:build": "node ./test/build-tests.mjs",
"test:clean": "yarn test --no-cache --coverage.clean",
"test:dev": "yarn test --coverage false",
Expand Down
2 changes: 1 addition & 1 deletion packages/kernel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
"lint:eslint": "eslint . --cache",
"lint:fix": "yarn constraints --fix && yarn lint:eslint --fix && yarn lint:misc --write",
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore",
"lint:ts": "tsc --project tsconfig.test.json --noEmit",
"publish:preview": "yarn npm publish --tag preview",
"test": "vitest run --config vitest.config.ts",
"test:ts": "tsc --project tsconfig.test.json --noEmit",
"test:clean": "yarn test --no-cache --coverage.clean",
"test:dev": "yarn test --coverage false",
"test:verbose": "yarn test --reporter verbose",
Expand Down
2 changes: 1 addition & 1 deletion packages/shims/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
"lint:eslint": "eslint . --cache",
"lint:fix": "yarn constraints --fix && yarn lint:eslint --fix && yarn lint:misc --write",
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore",
"lint:ts": "tsc --project tsconfig.test.json --noEmit",
"publish:preview": "yarn npm publish --tag preview",
"test": "vitest run --config vitest.config.ts",
"test:ts": "tsc --project tsconfig.test.json --noEmit",
"test:clean": "yarn test --no-cache --coverage.clean",
"test:dev": "yarn test --coverage false",
"test:verbose": "yarn test --reporter verbose",
Expand Down
2 changes: 1 addition & 1 deletion packages/streams/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@
"lint:eslint": "eslint . --cache",
"lint:fix": "yarn constraints --fix && yarn lint:eslint --fix && yarn lint:misc --write",
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore",
"lint:ts": "tsc --project tsconfig.test.json --noEmit",
"publish:preview": "yarn npm publish --tag preview",
"test": "vitest run --config vitest.config.ts",
"test:ts": "tsc --project tsconfig.test.json --noEmit",
"test:clean": "yarn test --no-cache --coverage.clean",
"test:dev": "yarn test --coverage false",
"test:verbose": "yarn test --reporter verbose",
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
"lint:eslint": "eslint . --cache",
"lint:fix": "yarn constraints --fix && yarn lint:eslint --fix && yarn lint:misc --write",
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.html' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path ../../.gitignore",
"lint:ts": "tsc --project tsconfig.test.json --noEmit",
"publish:preview": "yarn npm publish --tag preview",
"test": "vitest run --config vitest.config.ts",
"test:ts": "tsc --project tsconfig.test.json --noEmit",
"test:clean": "yarn test --no-cache --coverage.clean",
"test:dev": "yarn test --coverage false",
"test:verbose": "yarn test --reporter verbose",
Expand Down
2 changes: 1 addition & 1 deletion yarn.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ module.exports = defineConfig({
);
expectWorkspaceField(
workspace,
'scripts.test:ts',
'scripts.lint:ts',
'tsc --project tsconfig.test.json --noEmit',
);
expectWorkspaceField(
Expand Down