Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Nov 7, 2024

Ref: #218

Replaces stream envelopes with multiplex streams. This simplifies multiplexing traffic over the same underlying transport.

@rekmarks rekmarks requested a review from a team as a code owner November 7, 2024 05:22
@rekmarks rekmarks marked this pull request as draft November 7, 2024 05:23
@rekmarks rekmarks force-pushed the rekm/4-replace-envelopes branch from bc4a508 to f9d9ade Compare November 7, 2024 05:29
@rekmarks rekmarks linked an issue Nov 7, 2024 that may be closed by this pull request
@rekmarks rekmarks mentioned this pull request Nov 7, 2024
sirtimid
sirtimid previously approved these changes Nov 7, 2024
Comment on lines +45 to +52
const VatCommandReplyStruct = object({
id: VatMessageIdStruct,
payload: union([
object({ method: literal(VatCommandMethod.Evaluate), params: string() }),
object({ method: literal(VatCommandMethod.Ping), params: string() }),
object({ method: literal(VatCommandMethod.CapTpInit), params: string() }),
]),
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Base automatically changed from rekm/3-stream-multiplexer to main November 7, 2024 10:38
@rekmarks rekmarks dismissed sirtimid’s stale review November 7, 2024 10:38

The base branch was changed.

@rekmarks rekmarks force-pushed the rekm/4-replace-envelopes branch from f9d9ade to 1e87c78 Compare November 7, 2024 10:54
@rekmarks rekmarks marked this pull request as ready for review November 7, 2024 10:59
@rekmarks rekmarks merged commit 89e5003 into main Nov 7, 2024
@rekmarks rekmarks deleted the rekm/4-replace-envelopes branch November 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add stream multiplexing

3 participants