refactor: Replace message kits with superstruct types#224
Merged
Conversation
rekmarks
force-pushed
the
rekm/4-replace-envelopes
branch
from
bc4a508 to
f9d9ade
Compare
rekmarks
force-pushed
the
rekm/5-replace-message-kits
branch
from
6992b7e to
32a2722
Compare
This was referenced Nov 7, 2024
Closed
rekmarks
force-pushed
the
rekm/4-replace-envelopes
branch
from
f9d9ade to
1e87c78
Compare
rekmarks
force-pushed
the
rekm/5-replace-message-kits
branch
from
32a2722 to
551e1f3
Compare
sirtimid
previously approved these changes
Nov 7, 2024
rekmarks
force-pushed
the
rekm/5-replace-message-kits
branch
from
551e1f3 to
638798e
Compare
sirtimid
previously approved these changes
Nov 7, 2024
sirtimid
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces message kits and their associated types with
superstructequivalents. Also removes our CapTP messages types and replaces them withJson, because@endo/captpacceptsJsonand performs any further necessary validation internally.