fix: Vat restart functionality #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
force-pushed
the
sirtimid/vat-restart
branch
from
b905815 to
a953259
Compare
sirtimid
force-pushed
the
sirtimid/vat-restart
branch
from
7b2dfad to
13f776b
Compare
rekmarks
approved these changes
Nov 25, 2024
Member
rekmarks
left a comment
rekmarks
left a comment
There was a problem hiding this comment.
LGTM.
One question this raises for me though: do we need a notion of vat deletion, as distinct from vat termination? As of this PR, "terminate" means "stop + delete". Restart means "stop + delete + reinitialize from scratch (with the exception of the tiny state we maintain in the vat state service)". This is something to keep in mind once we have a distributed object graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236
This PR fixes the vat restart functionality in the kernel by properly preserving vat configuration and ID during restarts. Introduces a
VatStateServiceto manage this state.Future Extensions
The
VatStateServiceis designed to be simple now but could be extended to: