-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Establish simple CLI for serving user code #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
653aeb0 to
9b9f851
Compare
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! See inline comments for various suggestions.
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, the package should be added to the root tsconfig.json references field. If the package is built using ts-bridge (which I'm not sure should be the case), it should also be added to the root tsconfig.build.json. As long as we can build the CLI via yarn build and the run commands using yarn ocap <command>, we're good.
sirtimid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grypez can you also fix the E2E test workflow and the start:server command which is used in the playwright config?
moved to #265 |
Co-authored-by: Dimitris Marlagkoutsos <info@sirtimid.com>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #233
Adds the new
@ocap/clipackage and includes anocapbinary in the monorepo top level.ocap bundleUse the endo bundler to prepare the given
.jsfile, or every.jsfile in the given directory.ocap serveServe
.bundlefiles from the given directory, addressed relative to the directory.$ yarn ocap serve packages/extension/src/vats/ > serving packages/extension/src/vats/ on localhost:3000