Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Dec 6, 2024

Refactors the e2e test invocation to avoid a timed hangup of the server. We still start the server in parallel with Playwright, but we always close the server by killing its process after the tests end.

@rekmarks rekmarks marked this pull request as ready for review December 6, 2024 18:34
@rekmarks rekmarks requested a review from a team as a code owner December 6, 2024 18:35
Copy link
Contributor

@grypez grypez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@rekmarks rekmarks merged commit 032b36d into grypez/cli-integrate-e2e-tests Dec 6, 2024
15 checks passed
@rekmarks rekmarks deleted the rekm/e2e-test-script branch December 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants