Skip to content

Conversation

@grypez
Copy link
Contributor

@grypez grypez commented Jan 8, 2025

Adds the @ocap/nodejs package for running ocap kernel experiments in a nodejs environment.

@grypez grypez force-pushed the grypez/nodejs-pkg branch 2 times, most recently from f73b9ef to 1d423e8 Compare January 9, 2025 03:51
@socket-security
Copy link

socket-security bot commented Jan 9, 2025

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/better-sqlite3@7.6.12 None 0 9.48 kB types
npm/better-sqlite3@11.8.0 filesystem Transitive: environment, network +25 10.6 MB joshuawise

View full report↗︎

@socket-security
Copy link

socket-security bot commented Jan 9, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/tunnel-agent@0.6.0, npm/simple-get@4.0.1, npm/negotiator@1.0.0, npm/unique-slug@5.0.0, npm/@npmcli/fs@4.0.0, npm/unique-filename@4.0.0, npm/better-sqlite3@11.8.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@grypez grypez force-pushed the grypez/nodejs-pkg branch 3 times, most recently from 1f8775d to e3f5c5f Compare January 9, 2025 05:29
@grypez
Copy link
Contributor Author

grypez commented Jan 9, 2025

@SocketSecurity ignore npm/unique-slug@5.0.0
@SocketSecurity ignore npm/@npmcli/fs@4.0.0
@SocketSecurity ignore npm/unique-filename@4.0.0

The new author is npm-cli-ops

@grypez grypez force-pushed the grypez/nodejs-pkg branch from e3f5c5f to 4f1c41e Compare January 9, 2025 05:52
@grypez
Copy link
Contributor Author

grypez commented Jan 9, 2025

@SocketSecurity ignore npm/simple-get@4.0.1

Maintainer is the CEO of Socket

@grypez
Copy link
Contributor Author

grypez commented Jan 9, 2025

@SocketSecurity ignore npm/tunnel-agent@0.6.0
@SocketSecurity ignore npm/negotiator@1.0.0

Warily we accept these risks.

@grypez grypez force-pushed the grypez/nodejs-pkg branch from 4f1c41e to 350b994 Compare January 9, 2025 16:40
@grypez grypez marked this pull request as ready for review January 9, 2025 16:47
@grypez grypez requested a review from a team as a code owner January 9, 2025 16:47
@grypez grypez force-pushed the grypez/nodejs-pkg branch 2 times, most recently from 538b25b to 19c97dc Compare January 9, 2025 16:57
@grypez grypez force-pushed the grypez/nodejs-pkg branch from 19c97dc to 2c6e05f Compare January 9, 2025 20:30
@grypez grypez force-pushed the grypez/nodejs-pkg branch from cc20861 to c67a818 Compare January 9, 2025 21:02
@grypez grypez force-pushed the grypez/nodejs-pkg branch 3 times, most recently from 34de6d5 to d5424b0 Compare January 10, 2025 17:34
@grypez grypez force-pushed the grypez/nodejs-pkg branch from 8f311af to 461e61f Compare January 10, 2025 19:16
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mostly cosmetic changes I had queued up. Full review pending.

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
@rekmarks rekmarks mentioned this pull request Jan 14, 2025
3 tasks
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you start the Node kernel? I can't get the e2e tests to run.

@grypez grypez force-pushed the grypez/nodejs-pkg branch from 01e77e5 to e8420d9 Compare January 15, 2025 17:28
@rekmarks rekmarks linked an issue Jan 15, 2025 that may be closed by this pull request
4 tasks
@grypez grypez force-pushed the grypez/nodejs-pkg branch from e8420d9 to 47a81e9 Compare January 15, 2025 17:39
@grypez
Copy link
Contributor Author

grypez commented Jan 15, 2025

@SocketSecurity ignore npm/better-sqlite3@11.8.0

We want to use better-sqlite3 and its native code capabilities

@grypez
Copy link
Contributor Author

grypez commented Jan 15, 2025

How do you start the Node kernel? I can't get the e2e tests to run.

Added some e2e test docs 9e413e1

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor thing

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!!

@grypez grypez merged commit 89525ae into main Jan 16, 2025
16 checks passed
@grypez grypez deleted the grypez/nodejs-pkg branch January 16, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants