-
Notifications
You must be signed in to change notification settings - Fork 6
Add nodejs package #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodejs package #311
Conversation
f73b9ef to
1d423e8
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
1f8775d to
e3f5c5f
Compare
|
@SocketSecurity ignore npm/unique-slug@5.0.0 The new author is npm-cli-ops |
e3f5c5f to
4f1c41e
Compare
|
@SocketSecurity ignore npm/simple-get@4.0.1 Maintainer is the CEO of Socket |
|
@SocketSecurity ignore npm/tunnel-agent@0.6.0 Warily we accept these risks. |
4f1c41e to
350b994
Compare
538b25b to
19c97dc
Compare
19c97dc to
2c6e05f
Compare
cc20861 to
c67a818
Compare
34de6d5 to
d5424b0
Compare
8f311af to
461e61f
Compare
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some mostly cosmetic changes I had queued up. Full review pending.
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you start the Node kernel? I can't get the e2e tests to run.
01e77e5 to
e8420d9
Compare
e8420d9 to
47a81e9
Compare
|
@SocketSecurity ignore npm/better-sqlite3@11.8.0 We want to use better-sqlite3 and its native code capabilities |
Added some e2e test docs 9e413e1 |
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one minor thing
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!!
Adds the
@ocap/nodejspackage for running ocap kernel experiments in a nodejs environment.