chore: Clean up and document dummyMeterControl
#348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up and documents
dummyMeterControlper #341. In the course of doing this, a deeper look at how liveslots uses the meter control object revealed that some of the mechanism in the original Agoric version of this, which I just adopted wholesale and blindly translated to TypeScript, are actually required despite the fact that my initial assessment was that they were not and could be removed/simplified. However, the main thrust of the original complaint that prompted issue #341 was lack of clarity as to this file's function, so the issue is still relevant. I've cleaned up a couple of minor code infelicities and documented everything.Closes #341