feat: Add cluster config selector #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
reviewed
Jan 31, 2025
| "forceReset": true, | ||
| "vats": { | ||
| "main": { | ||
| "bundleSpec": "http://localhost:3000/sample-vat.bundle", |
Contributor
There was a problem hiding this comment.
The current sample vat assumes the three vat subcluster configuration and will most likely behave badly when run by itself. This is probably a good opportunity to set things up with more than one vat definition in the vats directory.
Contributor
Author
There was a problem hiding this comment.
Ok, I've added an empty one for now and we will revisit this config when we have another meaningful example vat to add.
sirtimid
force-pushed
the
sirtimid/multiple-sub-clusters
branch
from
e670e99 to
cf08539
Compare
rekmarks
previously approved these changes
Feb 3, 2025
Member
rekmarks
left a comment
rekmarks
left a comment
There was a problem hiding this comment.
Looks good, just needs conflict resolution.
sirtimid
force-pushed
the
sirtimid/multiple-sub-clusters
branch
from
0100819 to
046500a
Compare
rekmarks
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400
Adds a template selector dropdown to the ConfigEditor component that allows users to quickly switch between different cluster configurations (Default with Alice/Bob/Carol vats, or Minimal with single MainVat).