-
Notifications
You must be signed in to change notification settings - Fork 6
Test package for running cross-vat tests. And tests too. #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Ignoring: Next stepsWhat is manifest confusion?This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package. Packages with inconsistent metadata may be corrupted or malicious. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
@SocketSecurity ignore npm/abbrev@3.0.0 npm/async-function@1.0.0 npm/@agoric/store@0.9.3-upgrade-18a-dev-eaeaf5a.0 npm/@agoric/base-zone@0.1.1-upgrade-18a-dev-eaeaf5a.0 |
7474e1f to
5cbcf06
Compare
cba9889 to
3905360
Compare
3905360 to
21611c7
Compare
Includes test for various cases of liveslots <-> kernel promise handling. Closes #336
0627f53 to
7d6490c
Compare
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This adds a new
kernel-testpackage that has the machinery for running tests that involve message traffic being exchanged between vats.Also included are a bunch of tests for various cases of liveslots <-> kernel promise handling.
Note that this probably needs some build script love. While it has a bunch of vat code for running the various tests, the build process does not generate the bundles that the tests themselves expect to see. Right now this needs to be done manually, but really should be automated.
Closes #336