feat: Remove support for launching vats outside a subcluster #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
changed the title
rekmarks
reviewed
Jun 9, 2025
sirtimid
force-pushed
the
sirtimid/subclusters
branch
from
bca937f to
8b5d454
Compare
sirtimid
force-pushed
the
sirtimid/remove-public-launch-vat
branch
from
f225996 to
7c9465e
Compare
sirtimid
force-pushed
the
sirtimid/remove-public-launch-vat
branch
from
7c9465e to
53a0e20
Compare
grypez
previously requested changes
Jun 11, 2025
Contributor
grypez
left a comment
grypez
left a comment
There was a problem hiding this comment.
This change leaves dead code in support of rogue vats.
Since no rogue vats are started internally, privatizing #launchVat ought to make the getVatSubcluster method in the kernel store well-defined (if it returns undefined, either the given vat does not exist or the kernel has failed).
function getVatSubcluster(vatId: VatId): SubclusterId {
const currentMap = getVatToSubclusterMap();
return currentMap[vatId] ?? Fail`Vat ${vatId} has no subcluster`;
}Then the rogue vat code can be removed entirely.
packages/ocap-kernel/src/Kernel.ts
Outdated
| } | ||
| for (const vat of rogueVats) { | ||
| await this.launchVat(vat.config); | ||
| await this.#launchVat(vat.config); |
Contributor
There was a problem hiding this comment.
Suggested change
| await this.#launchVat(vat.config); |
I think we can remove this loop and the const rogueVats = ... entirely.
Contributor
Author
There was a problem hiding this comment.
Shoot.. I think my rebase messed up things a bit and I also forgot to clean up. Done 97bbd58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #532
Remove support for launching vats outside a subcluster.
Update all that rely on launching standalone vats.