Add `@ocap/kernel-agents` package #668

grypez · 2025-10-08T17:02:50Z

This PR introduces a new @ocap/kernel-agents package that provides capability-enabled AI agents.

Changes

New package `@ocap/kernel-agents`

provides a makeAgent factory for producing capability-augmented AI agents from a LanguageModel and a CapabilityRecord

`@ocap/kernel-language-model-service`

Updated LanguageModel.sample to return { stream, abort }, which allows downstream consumers to stop the LLM from generating more tokens (useful when you know the generation is invalid midstream)
Updated ollama service implementations to support the new sample interface

Note to Reviewers

See README.md for local e2e test setup.

Note

Adds a new capability-driven agent package and changes LanguageModel.sample to return an abortable stream ({ stream, abort }).

New package: @ocap/kernel-agents
- Agent factory makeAgent with default end capability and capability invocation flow.
- Prompt/transcript system (messages, prompt, example transcripts/capabilities) and incremental JSON streaming parser.
- Comprehensive unit + E2E tests (Ollama-based), README, build/test configs.
Language model service (@ocap/kernel-language-model-service)
- BREAKING: LanguageModel.sample now returns { stream, abort } (abortable streaming).
- Update Ollama base/nodejs implementations and tests to new interface; export root types entry.
Repo config
- Add packages/kernel-agents to TS project refs and Vitest coverage thresholds; workspace wiring in lockfile.

^{Written by Cursor Bugbot for commit 84cbf32. This will update automatically on new commits. Configure here.}

socket-security · 2025-10-08T17:13:28Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

rekmarks

It's great to see your sojourn in agent-land come together in such a well-conceived package. See various comments in-line. We should be able to get this merged in no time!

packages/kernel-agents/test/setup-e2e.ts

packages/kernel-agents/test/e2e/suite.test.ts

rekmarks · 2025-10-09T21:14:20Z

packages/kernel-agents/test/constants.ts

+/**
+ * Test constants for E2E tests
+ */
+export const DEFAULT_MODEL = 'llama3.1:latest';


Out of curiosity, how did we choose this and often do we expect to change it?

Fit for the test setup: available in ollama, relatively small
Fit for purpose: trained for tool use, trained to produce json outputs

In practice the prompts should be optimized to the models; the test suite is biased toward this choice of model.

rekmarks · 2025-10-09T21:15:31Z

packages/kernel-agents/test/constants.ts

Should the stuff in here be exported from the language service package? Or perhaps repo-tools?

Maybe later. The suite.test.ts tests that the local ollama server is running and prepared correctly (i.e. the model is pulled), which is a sort of liveness assurance above and beyond what the language service package promises. Putting the constants in repo-tools graduates them to a scope that exceeds current need.

This suggestion does point to broader question of separating the code and the data for the agent framework; for example, prompts are.... probably code? But also model dependent. And models are.... probably data? But we are using them to determine flow control of our program.

I think leaving these under the kernel-agents/test/ directory is the tidiest choice for the moment.

packages/kernel-agents/test/e2e/agent.test.ts

packages/kernel-agents/src/parser.ts

packages/kernel-agents/src/agent.ts

packages/kernel-agents/src/capability.test.ts

rekmarks · 2025-10-09T22:58:04Z

packages/kernel-agents/src/agent.ts

+  return {
+    task: async (
+      query: string,
+      { invocationBudget = 10 }: { invocationBudget?: number } = {},


What's this for?

It's the number of times the agent can invoke capabilities before the task throws. You can imagine that by the 10th call to a tool without completing the task, this particular approach is probably not going to succeed.

packages/kernel-agents/src/agent.test.ts

rekmarks

(I meant to request changes in my previous review)

addressed

rekmarks

LGTM!

Let's leave remaining comments unresolved. Some of it is documentation that should arguably be committed, but at least we can leave it easily accessible for Those Who Follow (i.e. ourselves, next week).

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>

cursor · 2025-10-15T11:10:05Z

packages/kernel-agents/src/agent.ts

+        logger?.info('results:', results);
+        const didEnd = results.find((capability) => capability.name === 'end');
+        if (didEnd) {
+          logger?.info('exit invocation with result:', didEnd.result);


Bug: Task Logs Missing Specific Context

The results and exit invocation logs on lines 84 and 87 use the general logger instead of the task-specific taskLogger. This causes these important task-related messages to miss their task context, like the task ID.

cursor · 2025-10-15T11:10:05Z

packages/kernel-agents/test/e2e/agent.test.ts

+      );
+      expect(result).toBeDefined();
+      expect(countSpy).toHaveBeenCalled();
+      expect(result).includes(word.length.toString());


Bug: Invalid Matcher Usage in Tests

The tests incorrectly use .includes() directly on the expect() object, which isn't a valid Vitest/Jest matcher. This means the assertions aren't checking what's intended.

Additional Locations (1)

packages/kernel-agents/test/e2e/agent.test.ts#L111-L112

This PR contains two minor fixes for the recently added kernel agents package (#668). - Two test expectations at the end of agent end to ends tests were no ops - The agent's task method was logging to the base logger instead of the taskLogger

grypez force-pushed the grypez/kernel-agent branch 4 times, most recently from 0f7fb26 to bbc62fa Compare October 9, 2025 13:11

grypez changed the title ~~WIP: kernel agents~~ Add @ocap/kernel-agents package Oct 9, 2025

grypez marked this pull request as ready for review October 9, 2025 16:30

grypez requested a review from a team as a code owner October 9, 2025 16:30

grypez mentioned this pull request Oct 9, 2025

Add kernel agents #649

Closed

4 tasks

rekmarks reviewed Oct 9, 2025

View reviewed changes

rekmarks previously requested changes Oct 9, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

grypez requested a review from rekmarks October 10, 2025 21:40

grypez mentioned this pull request Oct 14, 2025

Use external json stream parsing library #673

Open

grypez force-pushed the grypez/kernel-agent branch from d219945 to f748c0d Compare October 14, 2025 14:57

This comment was marked as outdated.

Sign in to view

rekmarks approved these changes Oct 14, 2025

View reviewed changes

grypez enabled auto-merge (squash) October 15, 2025 11:07

grypez and others added 11 commits October 15, 2025 07:07

feat(klms): add abortable stream support

199cbca

types(klms): export types

12efd46

feat: add kernel-agents (draft)

b961390

package configuration

42c8240

test infra

1ffd595

main feat implementation

939345a

thresholds

2b8f65b

add e2e testing docs

4c10546

Apply suggestions from code review

14c239c

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>

fix object schema type

0da9cd1

simplify fetchMock handling

238b9c2

grypez added 2 commits October 15, 2025 07:07

good bot: example transcripts

548907f

good bot: finally abort

84cbf32

grypez force-pushed the grypez/kernel-agent branch from 6437b85 to 84cbf32 Compare October 15, 2025 11:07

cursor bot reviewed Oct 15, 2025

View reviewed changes

grypez merged commit 6b4498b into main Oct 15, 2025
23 checks passed

grypez deleted the grypez/kernel-agent branch October 15, 2025 11:16

grypez mentioned this pull request Oct 15, 2025

fix(kernel-agents): test expectations and task logging #675

Merged

Add @ocap/kernel-agents package #668

Add @ocap/kernel-agents package #668

Uh oh!

Conversation

grypez commented Oct 8, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

New package @ocap/kernel-agents

@ocap/kernel-language-model-service

Note to Reviewers

Uh oh!

socket-security bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rekmarks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rekmarks Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

grypez Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

rekmarks Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

grypez Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rekmarks Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

grypez Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rekmarks left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

rekmarks left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Oct 15, 2025

Choose a reason for hiding this comment

Bug: Task Logs Missing Specific Context

Uh oh!

cursor bot Oct 15, 2025

Choose a reason for hiding this comment

Bug: Invalid Matcher Usage in Tests

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add `@ocap/kernel-agents` package #668

Add `@ocap/kernel-agents` package #668

grypez commented Oct 8, 2025 •

edited by cursor bot

Loading

New package `@ocap/kernel-agents`

`@ocap/kernel-language-model-service`

socket-security bot commented Oct 8, 2025 •

edited

Loading