build: Rename build:types package script to lint:types
#73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
approved these changes
Sep 16, 2024
rekmarks
added a commit
that referenced
this pull request
Sep 17, 2024
Adds build-time type checks to Vite via `vite-plugin-checker`, which we configure to run `tsc` as part of the Vite pipeline. As part of this, the `lint:types` script introduced in #73 (f.k.a. `build:types`, which was a misnomer) is removed. In essence, I first attempted to establish a `lint:types` script common across all packages. Any monorepo-wide implementation thereof turns out to be equivalent to just running a full, declaration-only TypeScript build of the entire monorepo (see [the TypeScript project references documentation](https://www.typescriptlang.org/docs/handbook/project-references.html) for details). This being the case, rather than using a one-off script for `@ocap/extension`, I found a Vite plugin that allows us to check types as part of the build process, as we do everywhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves: #72
Renames
build:typespackage script to the more appropriatelint:types.