Skip to content

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 4, 2023

Breaking change.

  • Drop support for Node.js major versions 14, 15, 17, 19
  • ci: Remove node.js v14 from tested versions
  • Dedupe and align @types/node devDependency

Blocked by

Blocking

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @types/node@18.0.0

@legobeat legobeat force-pushed the nodejs-16 branch 2 times, most recently from 06c6b61 to 97d4c56 Compare September 4, 2023 19:13
@legobeat legobeat marked this pull request as ready for review September 4, 2023 19:13
@legobeat legobeat requested review from a team, Gudahtt, kumavis, naugtur, rekmarks and weizman and removed request for a team and weizman September 4, 2023 19:13
Copy link
Contributor

@weizman weizman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, why types-node had to go through a version downgrade?

@legobeat
Copy link
Contributor Author

legobeat commented Sep 7, 2023

@weizman the idea is to match it with the lowest supported major runtime version, to make sure APIs match with what's available for the lowest common denominator.

@legobeat legobeat merged commit 210bd0d into MetaMask:main Sep 7, 2023
@legobeat legobeat deleted the nodejs-16 branch September 7, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants