fix: catch error when ethereum provider is set before our attempt to set #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
changed the title
jiexi
previously approved these changes
Apr 22, 2025
adonesky1
force-pushed
the
ad/catch-error-global-eth-provider-thrown
branch
from
51e207f to
cd54512
Compare
jiexi
approved these changes
Apr 22, 2025
Rashidsafwan
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when another wallet (currently only seeing this with Rabby) is installed and gets to the
ethereumglobal before us (and pulls up the ladder behind them) our provider errors out. This is now downstream causing our Solana Wallet Standard Provider to also fail to register.Though we cannot overcome this issue we can atleast prevent the subsequent provider registration from failing.
Related: MetaMask/metamask-extension#30685
Video Demo of Bug
Screen.Recording.2025-04-22.at.1.42.46.PM.mov
After
Screen.Recording.2025-04-22.at.1.42.46.PM.mov