Delay EthQuery instantiation until network provider is available
#274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronfigueiredo
force-pushed
the
feat/mm-2121
branch
from
3cbf637 to
a37a8fd
Compare
pedronfigueiredo
force-pushed
the
feat/mm-2121
branch
from
ca47f45 to
f503253
Compare
Contributor
|
@pedronfigueiredo What is the added method mentioned in the description? It seems like |
Contributor
Author
|
Thanks for the heads up @legobeat, I had forgotten to update the PR description. Should be fixed now. |
dan437
approved these changes
Mar 15, 2024
legobeat
added a commit
to legobeat/smart-transactions-controller
that referenced
this pull request
Mar 19, 2024
…lable (MetaMask#274)" This reverts commit 55b22e8.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, the network provider may no longer be defined when the Smart Transactions Controller is instantiated. As such, this PR initializes EthQuery to undefined, and
onNetworkStateChangedcan set it as soon as a provider is available.For more details on the reasoning behind this change, please see the linked PRs and issues.