Provide metadata when signing delegation #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the GatorPermissionsSnap submits the delegation for signing via
eth_signTypedData_v4, it must include metadata - the justification, and origin of the request, as part of the eip-712 payload.Related issues
MetaMask/core#6619
MetaMask/core#6656
MetaMask/metamask-extension#36054
Manual testing steps
a. Has the above PRs integrated
b. Has the
GATOR_PERMISSIONS_ENABLEDenvironment variable set totruelocalhost:8000if using the site from the snap monorepo, and "This is a very important request for streaming allowance for some very important thing" if you don't change it)Screenshots/Recordings
Before
Error would be shown, because no metadata is included in the request.
After
Pre-merge author checklist
Pre-merge reviewer checklist