Skip to content

feat: pre installed snap script #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
owencraston merged 1 commit into from
Sep 3, 2024
Merged

feat: pre installed snap script #146

owencraston merged 1 commit into from
Sep 3, 2024

Conversation

@owencraston
Copy link
Contributor

@owencraston owencraston commented Aug 29, 2024 •
edited
Loading

steps

  • run yarn run build-preinstalled-snap
    there should be a local bundle file created.

@owencraston owencraston marked this pull request as ready for review September 3, 2024 20:47
@owencraston owencraston requested a review from a team as a code owner September 3, 2024 20:47
k-g-j
k-g-j approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@k-g-j k-g-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and was able to build the preinstalled-snap.json

@owencraston owencraston merged commit e0860be into main Sep 3, 2024
@owencraston owencraston deleted the feat/pre-installed-snap branch September 3, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@k-g-j k-g-j k-g-j approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@owencraston @k-g-j