Skip to content

Conversation

@rekmarks
Copy link
Member

#19 removed the plugin metadata parameter from setupWorkerConnection. That function is actually used to setup to plugin provider connection (it ultimately calls setupUntrustedCommunication in the extension background, see here), and it needs at least the plugin name in order to do that.

This PR renames setupWorkerConnection to setupPluginProvider – which actually describes what it does – and adds a pluginName parameter.

@rekmarks rekmarks merged commit 0ce2b7d into main Jun 17, 2021
@rekmarks rekmarks deleted the fix-worker-stream-initialization branch June 17, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants