perf: Unload iframe before removing #3796
Merged
+34
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To drastically reduce the amount of memory leaked if the iframe cannot be garbage collected properly, this PR modifies
terminateJobto navigate the iframe away from the Snaps execution environment before removing it, effectively unloading it.Before:
After:
Note
Improves termination flow and reduces iframe memory retention by making job termination asynchronous and explicitly unloading iframes before removal.
AbstractExecutionService.terminateJobto return aPromise<void>and awaits it interminateSnapand when init times out in#initStreamsIframeExecutionService,terminateJobnow navigates the iframe toabout:blank(with a shortwithTimeout-guarded wait forload) before removing itNodeProcessExecutionServiceandWebViewExecutionServiceterminateJobimplementations to async (no functional change beyond signature)Written by Cursor Bugbot for commit c5ec278. This will update automatically on new commits. Configure here.