fix: Ensure iframe load listener is removed #3797
Merged
+17
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the load listener for the iframe is removed after the promise resolves. Found while investigating a memory leak, but does not fix it.
Note
Ensures the iframe
loadhandler is one-time and self-cleaning.iframe.tsto useaddEventListener('load', handler, { once: true }), so the listener automatically removes itself after resolving/rejecting, preventing duplicate fires and lingering listenersWritten by Cursor Bugbot for commit 56dce3b. This will update automatically on new commits. Configure here.