forked from ianstormtaylor/superstruct
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add exactOptional struct
#32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
617f20a
feat: Add strictOptional struct
rekmarks 9f4c709
refactor: Cleanup
rekmarks 64156a4
refactor: Get rid of ts-expect-error directive
rekmarks d261561
feat: Prefix strictOptional type string with "optional"
rekmarks 3f1e13b
refactor: Apply suggestions from code review, rename to exactOptional
rekmarks 368778e
refactor: strict -> exact
rekmarks bc66cf8
docs: Add comment explaining private brand field
rekmarks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { | ||
| assert, | ||
| exactOptional, | ||
| string, | ||
| number, | ||
| object, | ||
| enums, | ||
| } from '../../src'; | ||
| import { test } from '../index.test'; | ||
|
|
||
| test<string | undefined>((value) => { | ||
| assert(value, exactOptional(string())); | ||
| return value; | ||
| }); | ||
|
|
||
| test<{ | ||
| a?: number; | ||
| b: string; | ||
| c?: 'a' | 'b'; | ||
| d?: { | ||
| e: string; | ||
| }; | ||
| f?: { | ||
| g?: { | ||
| h: string; | ||
| }; | ||
| }; | ||
| }>((value) => { | ||
| assert( | ||
| value, | ||
| object({ | ||
| a: exactOptional(number()), | ||
| b: string(), | ||
| c: exactOptional(enums(['a', 'b'])), | ||
| d: exactOptional( | ||
| object({ | ||
| e: string(), | ||
| }), | ||
| ), | ||
| f: exactOptional( | ||
| object({ | ||
| g: exactOptional(object({ h: string() })), | ||
| }), | ||
| ), | ||
| }), | ||
| ); | ||
| return value; | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment to clarify why this is necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bc66cf8