Fix ExactOptionalize changing never to undefined
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmalik88
reviewed
Apr 3, 2025
hmalik88
left a comment
hmalik88
left a comment
There was a problem hiding this comment.
Maybe we should add some tests for these utils?
Mrtenz
force-pushed
the
mrtenz/fix-never-type
branch
from
e16b153 to
802df0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neveris a subtype of all types, so in this case, ifSchema[K]is never,Kis used:This is problematic when using a struct type like
Record<string, never>. This was previously incorrectly changed intoRecord<string, undefined>. After this change, the type is not affected.