Skip to content

Conversation

@dependabot
Copy link

@dependabot dependabot bot commented on behalf of github Apr 15, 2024

Bumps @metamask/controller-utils from 8.0.3 to 9.1.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from dan437 as a code owner April 15, 2024 00:53
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 15, 2024
@dependabot dependabot bot requested a review from a team April 15, 2024 00:53
@socket-security
Copy link

socket-security bot commented Apr 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/controller-utils@9.1.0 network Transitive: filesystem +11 2.93 MB metamaskbot

🚮 Removed packages: npm/@metamask/controller-utils@8.0.4

View full report↗︎

@socket-security
Copy link

socket-security bot commented Apr 15, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/@spruceid/siwe-parser@2.1.0
Unstable ownership npm/@spruceid/siwe-parser@2.1.0

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@spruceid/siwe-parser@2.1.0

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controller-utils-9.1.0 branch 2 times, most recently from 6ded752 to 5050f91 Compare April 16, 2024 13:08
Bumps [@metamask/controller-utils](https://github.com/MetaMask/core) from 8.0.3 to 9.1.0.
- [Release notes](https://github.com/MetaMask/core/releases)
- [Changelog](https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md)
- [Commits](https://github.com/MetaMask/core/compare/@metamask/controller-utils@8.0.3...@metamask/controller-utils@9.1.0)

---
updated-dependencies:
- dependency-name: "@metamask/controller-utils"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/metamask/controller-utils-9.1.0 branch from 5050f91 to 9c0e72a Compare April 16, 2024 13:44
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test error:

Error: src/swapsUtil.ts(286,27): error TS2345: Argument of type 'BigNumber' is not assignable to parameter of type 'BN'.
  Type 'BigNumber' is missing the following properties from type 'BN': clone, toArray, toArrayLike, toBuffer, and 72 more.
Error: src/swapsUtil.ts(287,24): error TS2345: Argument of type 'number | BigNumber' is not assignable to parameter of type 'BN'.
  Type 'number' is not assignable to type 'BN'.

@nikoferro @dan437 Maybe it's about time this package migrated off from bignumber.js and onto bn.js (if not native bigint)? Or is there some reason why bignumber.js would still be preferred here?

@legobeat
Copy link
Contributor

I guess this is blocked by getting transient versions in line first?

@nikoferro nikoferro closed this Apr 17, 2024
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Apr 17, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/metamask/controller-utils-9.1.0 branch April 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants