fix: add @metamask/composable-controller to peerDependencies #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
commented
Apr 16, 2024
package.json
Outdated
| "build": "tsc --project ." | ||
| }, | ||
| "peerDependencies": { | ||
| "@metamask/composable-controller": "^1.0.2" |
Contributor
Author
There was a problem hiding this comment.
Maybe we actually want to match the version already used in metamask-mobile here?
If so, we should also bump the devDependencies version correspondingly, to have it covered in tests.
legobeat
force-pushed
the
peerdeps-composable-controller
branch
from
d5cd0a1 to
43bc74e
Compare
legobeat
force-pushed
the
peerdeps-composable-controller
branch
from
43bc74e to
aa8f33d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be good to indicate supported version of
@metamask/composable-controller. This adds it topeerDependencies.Based on